2015-04-26 09:42:14

by Yunzhi Li

Subject: [PATCH v1 1/2] ARM: dts: rockchip: add properties for dwc2 usb otg controller

Add properties for dwc2 usb device controller according to
Documentation/devicetree/bindings/usb/dwc2.txt

Signed-off-by: Yunzhi Li <[email protected]>
---

arch/arm/boot/dts/rk3288.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index eccc78d..2b55b07 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -432,6 +432,7 @@
interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru HCLK_USBHOST1>;
clock-names = "otg";
+ dr_mode = "host";
status = "disabled";
};

@@ -442,6 +443,11 @@
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru HCLK_OTG0>;
clock-names = "otg";
+ dr_mode = "otg";
+ g-np-tx-fifo-size = <16>;
+ g-rx-fifo-size = <275>;
+ g-tx-fifo-size = <256 128 128 64 64 32>;
+ g-use-dma;
status = "disabled";
};

--
2.0.0

2015-04-26 09:42:17

by Yunzhi Li

Subject: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

rk3288-firefly board use the dwc2 usb otg controller as a host
controller and the device mode not used, so the dr_mode should be
"host" then the dwc2 usb otg controller will work at host only
mode

Signed-off-by: Yunzhi Li <[email protected]>

---

arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
index e6f873a..a861776 100644
--- a/arch/arm/boot/dts/rk3288-firefly.dtsi
+++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
@@ -466,6 +466,7 @@
};

&usb_otg {
+ dr_modr = "host";
status = "okay";
};

--
2.0.0

2015-04-26 10:16:31

by Heiko Stübner

Subject: Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

Hi,

Am Sonntag, 26. April 2015, 17:41:39 schrieb Yunzhi Li:
> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode
>
> Signed-off-by: Yunzhi Li <[email protected]>

Not sure I understand. Is this some sort of hardware limitation? Because when
for example flashing a kernel via upgrade_tool it is working just fine as
gadget.

If it is a software choice, this should not be made in the devicetree, as the
dt describes the hardware alone.


Heiko


>
> ---
>
> arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi
> b/arch/arm/boot/dts/rk3288-firefly.dtsi index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
> };
>
> &usb_otg {
> + dr_modr = "host";
> status = "okay";
> };

2015-04-26 11:12:11

by Sergei Shtylyov

Subject: Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

Hello.

On 4/26/2015 12:41 PM, Yunzhi Li wrote:

> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode

> Signed-off-by: Yunzhi Li <[email protected]>

> ---

> arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
> 1 file changed, 1 insertion(+)

> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
> index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
> };
>
> &usb_otg {
> + dr_modr = "host";

You meant to type "dr_mode".

WBR, Sergei

2015-04-28 21:00:19

by Heiko Stübner

Subject: Re: [PATCH v1 1/2] ARM: dts: rockchip: add properties for dwc2 usb otg controller

Am Sonntag, 26. April 2015, 17:41:38 schrieb Yunzhi Li:
> Add properties for dwc2 usb device controller according to
> Documentation/devicetree/bindings/usb/dwc2.txt
>
> Signed-off-by: Yunzhi Li <[email protected]>

applied to my dts branch for 4.2


thanks
Heiko