2015-06-05 14:36:19

by Paul Gortmaker

Subject: [PATCH] tile: add init.h to usb.c to avoid compile failure

Pending header cleanups will reveal this file is using the
init.h content implicitly with the following fail:

arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default]
arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall'
arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default]
arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used

Explicitly add init.h to get arch_initcall and avoid this.

Reported-by: kbuild test robot <[email protected]>
Cc: Chris Metcalf <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>
---

[adding this to the header move series of commits; see
https://lkml.kernel.org/r/[email protected]
for original series posting. ]

arch/tile/kernel/usb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/tile/kernel/usb.c b/arch/tile/kernel/usb.c
index 5af8debc6a71..f0da5a237e94 100644
--- a/arch/tile/kernel/usb.c
+++ b/arch/tile/kernel/usb.c
@@ -21,6 +21,7 @@
#include <linux/dma-mapping.h>
#include <linux/platform_device.h>
#include <linux/usb/tilegx.h>
+#include <linux/init.h>
#include <linux/types.h>

static u64 ehci_dmamask = DMA_BIT_MASK(32);
--
2.2.1

2015-06-05 14:42:59

by Chris Metcalf

Subject: Re: [PATCH] tile: add init.h to usb.c to avoid compile failure

On 06/05/2015 10:36 AM, Paul Gortmaker wrote:
> Pending header cleanups will reveal this file is using the
> init.h content implicitly with the following fail:
>
> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default]
> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall'
> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default]
> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used
>
> Explicitly add init.h to get arch_initcall and avoid this.
>
> Reported-by: kbuild test robot<[email protected]>
> Cc: Chris Metcalf<[email protected]>
> Signed-off-by: Paul Gortmaker<[email protected]>
> ---
>
> [adding this to the header move series of commits; see
> https://lkml.kernel.org/r/[email protected]
> for original series posting. ]
>
> arch/tile/kernel/usb.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Chris Metcalf <[email protected]>

or I'm happy to take it into the tile tree if you'd rather I did.

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

2015-06-05 14:46:30

by Paul Gortmaker

Subject: Re: [PATCH] tile: add init.h to usb.c to avoid compile failure

On 15-06-05 10:42 AM, Chris Metcalf wrote:
> On 06/05/2015 10:36 AM, Paul Gortmaker wrote:
>> Pending header cleanups will reveal this file is using the
>> init.h content implicitly with the following fail:
>>
>> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default]
>> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall'
>> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default]
>> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used
>>
>> Explicitly add init.h to get arch_initcall and avoid this.
>>
>> Reported-by: kbuild test robot<[email protected]>
>> Cc: Chris Metcalf<[email protected]>
>> Signed-off-by: Paul Gortmaker<[email protected]>
>> ---
>>
>> [adding this to the header move series of commits; see
>> https://lkml.kernel.org/r/[email protected]
>> for original series posting. ]
>>
>> arch/tile/kernel/usb.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Acked-by: Chris Metcalf <[email protected]>
>
> or I'm happy to take it into the tile tree if you'd rather I did.

Thanks, I'll carry it since I'd risk introducing bisection failures
if my header changes go in without this being present 1st.

Paul.