2015-06-10 16:31:14

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] mmc: queue: use swap() in mmc_queue_thread()

Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/mmc/card/queue.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
index 8efa368..d34e09b 100644
--- a/drivers/mmc/card/queue.c
+++ b/drivers/mmc/card/queue.c
@@ -56,7 +56,6 @@ static int mmc_queue_thread(void *d)
down(&mq->thread_sem);
do {
struct request *req = NULL;
- struct mmc_queue_req *tmp;
unsigned int cmd_flags = 0;

spin_lock_irq(q->queue_lock);
@@ -86,9 +85,7 @@ static int mmc_queue_thread(void *d)

mq->mqrq_prev->brq.mrq.data = NULL;
mq->mqrq_prev->req = NULL;
- tmp = mq->mqrq_prev;
- mq->mqrq_prev = mq->mqrq_cur;
- mq->mqrq_cur = tmp;
+ swap(mq->mqrq_prev, mq->mqrq_cur);
} else {
if (kthread_should_stop()) {
set_current_state(TASK_RUNNING);
--
2.4.2

2015-06-15 09:54:42

by Ulf Hansson

Subject: Re: [PATCH 1/1 linux-next] mmc: queue: use swap() in mmc_queue_thread()

On 10 June 2015 at 18:30, Fabian Frederick <[email protected]> wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Thanks, applied.

Kind regards
Uffe

> ---
> drivers/mmc/card/queue.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
> index 8efa368..d34e09b 100644
> --- a/drivers/mmc/card/queue.c
> +++ b/drivers/mmc/card/queue.c
> @@ -56,7 +56,6 @@ static int mmc_queue_thread(void *d)
> down(&mq->thread_sem);
> do {
> struct request *req = NULL;
> - struct mmc_queue_req *tmp;
> unsigned int cmd_flags = 0;
>
> spin_lock_irq(q->queue_lock);
> @@ -86,9 +85,7 @@ static int mmc_queue_thread(void *d)
>
> mq->mqrq_prev->brq.mrq.data = NULL;
> mq->mqrq_prev->req = NULL;
> - tmp = mq->mqrq_prev;
> - mq->mqrq_prev = mq->mqrq_cur;
> - mq->mqrq_cur = tmp;
> + swap(mq->mqrq_prev, mq->mqrq_cur);
> } else {
> if (kthread_should_stop()) {
> set_current_state(TASK_RUNNING);
> --
> 2.4.2
>