2015-06-17 01:42:11

by Y Vo

[permalink] [raw]
Subject: [PATCH v0] arm64: dts: Add poweroff button device node for APM X-Gene platform

This patch adds poweroff button device node to support poweroff feature
on APM X-Gene Mustang platform.

Signed-off-by: Y Vo <[email protected]>
---
arch/arm64/boot/dts/apm/apm-mustang.dts | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b/arch/arm64/boot/dts/apm/apm-mustang.dts
index 83578e7..67979c8 100644
--- a/arch/arm64/boot/dts/apm/apm-mustang.dts
+++ b/arch/arm64/boot/dts/apm/apm-mustang.dts
@@ -23,6 +23,17 @@
device_type = "memory";
reg = < 0x1 0x00000000 0x0 0x80000000 >; /* Updated by bootloader */
};
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ apm_ctrl_name = "Power Button";
+ btn3 {
+ label = "EXT_PWR";
+ linux,code = <116>;
+ linux,input-type = <0x1>; /* EV_KEY */
+ interrupts = <0x0 0x2d 0x1>;
+ };
+ };
};

&pcie0clk {
--
1.7.1


2015-06-25 15:10:05

by Mark Rutland

[permalink] [raw]
Subject: Re: [PATCH v0] arm64: dts: Add poweroff button device node for APM X-Gene platform

On Wed, Jun 17, 2015 at 02:41:52AM +0100, Y Vo wrote:
> This patch adds poweroff button device node to support poweroff feature
> on APM X-Gene Mustang platform.
>
> Signed-off-by: Y Vo <[email protected]>
> ---
> arch/arm64/boot/dts/apm/apm-mustang.dts | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b/arch/arm64/boot/dts/apm/apm-mustang.dts
> index 83578e7..67979c8 100644
> --- a/arch/arm64/boot/dts/apm/apm-mustang.dts
> +++ b/arch/arm64/boot/dts/apm/apm-mustang.dts
> @@ -23,6 +23,17 @@
> device_type = "memory";
> reg = < 0x1 0x00000000 0x0 0x80000000 >; /* Updated by bootloader */
> };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + apm_ctrl_name = "Power Button";

Huh?

Undocumented, unused, and doesn't follwo the "vendor,property" naming
scheme...

Mark.

> + btn3 {
> + label = "EXT_PWR";
> + linux,code = <116>;
> + linux,input-type = <0x1>; /* EV_KEY */
> + interrupts = <0x0 0x2d 0x1>;
> + };
> + };
> };
>
> &pcie0clk {
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>