2015-07-28 18:52:00

by Ray Jui

[permalink] [raw]
Subject: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig

The current iProc BCMA front-end driver can only work on ARM32 based
platforms; therefore its config option in Kconfig should be changed to
reflect that. This fixes arm64 allmodconfig build failure when compiling
the the iProc BCMA driver that contains struct pci_sys_data that is
arm32 specific

Signed-off-by: Ray Jui <[email protected]>
---
drivers/pci/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index d2c6144..2cc9afe 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -136,7 +136,7 @@ config PCIE_IPROC_PLATFORM

config PCIE_IPROC_BCMA
bool "Broadcom iProc PCIe BCMA bus driver"
- depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
+ depends on ARCH_BCM_IPROC && ARM
select PCIE_IPROC
select BCMA
select PCI_DOMAINS
--
1.7.9.5


2015-07-29 14:31:00

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig

On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
> config PCIE_IPROC_BCMA
> bool "Broadcom iProc PCIe BCMA bus driver"
> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
> + depends on ARCH_BCM_IPROC && ARM
> select PCIE_IPROC
> select BCMA
> select PCI_DOMAINS
>

How about this:

depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)

That would leave the compile test present for non-iproc
ARM platforms while preventing ARM64 and MIPS builds with
ARCH_BCM_IPROC set.

Arnd

2015-07-29 16:17:07

by Ray Jui

[permalink] [raw]
Subject: Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig



On 7/29/2015 7:30 AM, Arnd Bergmann wrote:
> On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
>> config PCIE_IPROC_BCMA
>> bool "Broadcom iProc PCIe BCMA bus driver"
>> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>> + depends on ARCH_BCM_IPROC && ARM
>> select PCIE_IPROC
>> select BCMA
>> select PCI_DOMAINS
>>
>
> How about this:
>
> depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
>
> That would leave the compile test present for non-iproc
> ARM platforms while preventing ARM64 and MIPS builds with
> ARCH_BCM_IPROC set.
>
> Arnd
>

That is indeed better. Broader compile test coverage is always good.
I'll submit another patch with the above suggested change.

Thanks,

Ray