2015-11-06 10:06:08

by SF Markus Elfring

Subject: [PATCH] cxl: Delete an unnecessary check before the function call "kfree"

From: Markus Elfring <[email protected]>
Date: Fri, 6 Nov 2015 11:00:23 +0100

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/misc/cxl/context.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/cxl/context.c b/drivers/misc/cxl/context.c
index 2faa127..52e39b6 100644
--- a/drivers/misc/cxl/context.c
+++ b/drivers/misc/cxl/context.c
@@ -275,9 +275,7 @@ static void reclaim_ctx(struct rcu_head *rcu)
if (ctx->kernelapi)
kfree(ctx->mapping);

- if (ctx->irq_bitmap)
- kfree(ctx->irq_bitmap);
-
+ kfree(ctx->irq_bitmap);
kfree(ctx);
}

--
2.6.2

2015-11-08 22:57:32

by Andrew Donnellan

Subject: Re: [PATCH] cxl: Delete an unnecessary check before the function call "kfree"

On 06/11/15 21:05, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Fri, 6 Nov 2015 11:00:23 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Thanks for picking this up - will remember in my future patches.

Reviewed-by: Andrew Donnellan <[email protected]>

--
Andrew Donnellan Software Engineer, OzLabs
[email protected] Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited

2015-11-09 02:11:00

by Ian Munsie

Subject: Re: [PATCH] cxl: Delete an unnecessary check before the function call "kfree"

Acked-by: Ian Munsie <[email protected]>

2016-04-13 13:33:38

by Michael Ellerman

Subject: Re: cxl: Delete an unnecessary check before the function call "kfree"

On Fri, 2015-06-11 at 10:05:46 UTC, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Fri, 6 Nov 2015 11:00:23 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> Reviewed-by: Andrew Donnellan <[email protected]>
> Acked-by: Ian Munsie <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1050e689a63baffdadcd33498c

cheers