2015-11-10 00:22:56

by Alexey Klimov

Subject: [PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages_range()

Before usage page pointer initialized by NULL is reinitialized by
follow_page_mask(). Drop useless init of page pointer in the beginning
of loop.

Signed-off-by: Alexey Klimov <[email protected]>
---
mm/mlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/mlock.c b/mm/mlock.c
index 339d9e0..9cb87cb 100644
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -425,7 +425,7 @@ void munlock_vma_pages_range(struct vm_area_struct *vma,
vma->vm_flags &= VM_LOCKED_CLEAR_MASK;

while (start < end) {
- struct page *page = NULL;
+ struct page *page;
unsigned int page_mask;
unsigned long page_increm;
struct pagevec pvec;
--
2.5.0

2015-11-10 09:27:05

by Vlastimil Babka

Subject: Re: [PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages_range()

On 11/10/2015 01:22 AM, Alexey Klimov wrote:
> Before usage page pointer initialized by NULL is reinitialized by
> follow_page_mask(). Drop useless init of page pointer in the beginning
> of loop.
>
> Signed-off-by: Alexey Klimov <[email protected]>

Acked-by: Vlastimil Babka <[email protected]>

> ---
> mm/mlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 339d9e0..9cb87cb 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -425,7 +425,7 @@ void munlock_vma_pages_range(struct vm_area_struct *vma,
> vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
>
> while (start < end) {
> - struct page *page = NULL;
> + struct page *page;
> unsigned int page_mask;
> unsigned long page_increm;
> struct pagevec pvec;
>