2015-11-25 10:26:28

by Peng Fan

Subject: [RFC 1/1] xen: block: correct setting for xen_blkif_max_ring_order

According to this piece code:
"
pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER);
"
if xen_blkif_max_ring_order is bigger that XENBUS_MAX_RING_GRANT_ORDER,
need to set xen_blkif_max_ring_order using XENBUS_MAX_RING_GRANT_ORDER,
but not 0.

Signed-off-by: Peng Fan <[email protected]>
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Boris Ostrovsky <[email protected]>
Cc: David Vrabel <[email protected]>
Cc: "Roger Pau Monné" <[email protected]>
---

Hi,

I am new to xen and reading related soure code, not sure whether
this is correct. Please comments.

Thanks

drivers/block/xen-blkfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 0823a96..883b9fa 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2126,7 +2126,7 @@ static int __init xlblk_init(void)
if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) {
pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER);
- xen_blkif_max_ring_order = 0;
+ xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER;
}

if (!xen_has_pv_disk_devices())
--
2.6.2

2015-11-25 16:54:12

by Konrad Rzeszutek Wilk

Subject: Re: [RFC 1/1] xen: block: correct setting for xen_blkif_max_ring_order

On Wed, Nov 25, 2015 at 06:26:01PM +0800, Peng Fan wrote:
> According to this piece code:
> "
> pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
> xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER);
> "
> if xen_blkif_max_ring_order is bigger that XENBUS_MAX_RING_GRANT_ORDER,
> need to set xen_blkif_max_ring_order using XENBUS_MAX_RING_GRANT_ORDER,
> but not 0.
>
> Signed-off-by: Peng Fan <[email protected]>
> Cc: Konrad Rzeszutek Wilk <[email protected]>
> Cc: Boris Ostrovsky <[email protected]>
> Cc: David Vrabel <[email protected]>
> Cc: "Roger Pau Monn?" <[email protected]>
> ---
>
> Hi,
>
> I am new to xen and reading related soure code, not sure whether
> this is correct. Please comments.

Applied to 'devel/for-jens-4.5'.

Thanks!
>
> Thanks
>
> drivers/block/xen-blkfront.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 0823a96..883b9fa 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -2126,7 +2126,7 @@ static int __init xlblk_init(void)
> if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) {
> pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
> xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER);
> - xen_blkif_max_ring_order = 0;
> + xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER;
> }
>
> if (!xen_has_pv_disk_devices())
> --
> 2.6.2
>