2015-11-26 12:36:28

by Chaotian Jing

Subject: [PATCH v2] mmc: core: fix __mmc_switch timeout caused by preempt

there is a time window between __mmc_send_status() and time_afer(),
on some eMMC chip, the timeout_ms is only 10ms, if this thread was
scheduled out during this period, then, even card has already changes
to transfer state by the result of CMD13, this part of code also treat
it to timeout error.
So, need calculate timeout first, then call __mmc_send_status(), if
already timeout and card still in programing state, then treat it to
the real timeout error.

Signed-off-by: Chaotian Jing <[email protected]>
---
drivers/mmc/core/mmc_ops.c | 23 +++++++++++++++--------
1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 1f44426..eba5295 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -489,6 +489,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
unsigned long timeout;
u32 status = 0;
bool use_r1b_resp = use_busy_signal;
+ bool expired;

mmc_retune_hold(host);

@@ -545,9 +546,23 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
timeout = jiffies + msecs_to_jiffies(timeout_ms);
do {
if (send_status) {
+ /*
+ * Timeout if the device never leaves the program state.
+ * Due to the possibility of being preempted after
+ * sending the status command, check the expiration
+ * time first.
+ */
+ expired = time_after(jiffies, timeout);
err = __mmc_send_status(card, &status, ignore_crc);
if (err)
goto out;
+ if (expired &&
+ R1_CURRENT_STATE(status) == R1_STATE_PRG) {
+ pr_err("%s: Card stuck in programming state! %s\n",
+ mmc_hostname(host), __func__);
+ err = -ETIMEDOUT;
+ goto out;
+ }
}
if ((host->caps & MMC_CAP_WAIT_WHILE_BUSY) && use_r1b_resp)
break;
@@ -563,14 +578,6 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
mmc_delay(timeout_ms);
goto out;
}
-
- /* Timeout if the device never leaves the program state. */
- if (time_after(jiffies, timeout)) {
- pr_err("%s: Card stuck in programming state! %s\n",
- mmc_hostname(host), __func__);
- err = -ETIMEDOUT;
- goto out;
- }
} while (R1_CURRENT_STATE(status) == R1_STATE_PRG);

err = mmc_switch_status_error(host, status);
--
1.8.1.1.dirty

2015-11-26 21:17:47

by Ulf Hansson

Subject: Re: [PATCH v2] mmc: core: fix __mmc_switch timeout caused by preempt

On 26 November 2015 at 13:36, Chaotian Jing <[email protected]> wrote:
> there is a time window between __mmc_send_status() and time_afer(),
> on some eMMC chip, the timeout_ms is only 10ms, if this thread was
> scheduled out during this period, then, even card has already changes
> to transfer state by the result of CMD13, this part of code also treat
> it to timeout error.
> So, need calculate timeout first, then call __mmc_send_status(), if
> already timeout and card still in programing state, then treat it to
> the real timeout error.
>
> Signed-off-by: Chaotian Jing <[email protected]>
> ---
> drivers/mmc/core/mmc_ops.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index 1f44426..eba5295 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -489,6 +489,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> unsigned long timeout;
> u32 status = 0;
> bool use_r1b_resp = use_busy_signal;
> + bool expired;
>
> mmc_retune_hold(host);
>
> @@ -545,9 +546,23 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> timeout = jiffies + msecs_to_jiffies(timeout_ms);
> do {
> if (send_status) {
> + /*
> + * Timeout if the device never leaves the program state.
> + * Due to the possibility of being preempted after
> + * sending the status command, check the expiration
> + * time first.
> + */
> + expired = time_after(jiffies, timeout);
> err = __mmc_send_status(card, &status, ignore_crc);
> if (err)
> goto out;
> + if (expired &&
> + R1_CURRENT_STATE(status) == R1_STATE_PRG) {
> + pr_err("%s: Card stuck in programming state! %s\n",
> + mmc_hostname(host), __func__);
> + err = -ETIMEDOUT;
> + goto out;
> + }

This "if" actually means we will start verifying the card state, even
when "MMC_CAP_WAIT_WHILE_BUSY && use_r1b_resp". I don't think we need
or should.

Instead let's move this code at its original place below. That also
means you indeed need to assign an initial value for "expired" to
"false" in the beginning of the function.

Apologize for not spotting this change in behaviour in v1.

> }
> if ((host->caps & MMC_CAP_WAIT_WHILE_BUSY) && use_r1b_resp)
> break;
> @@ -563,14 +578,6 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> mmc_delay(timeout_ms);
> goto out;
> }
> -
> - /* Timeout if the device never leaves the program state. */
> - if (time_after(jiffies, timeout)) {
> - pr_err("%s: Card stuck in programming state! %s\n",
> - mmc_hostname(host), __func__);
> - err = -ETIMEDOUT;
> - goto out;
> - }
> } while (R1_CURRENT_STATE(status) == R1_STATE_PRG);
>
> err = mmc_switch_status_error(host, status);
> --
> 1.8.1.1.dirty
>

Kind regards
Uffe