2015-12-02 21:46:22

by Geyslan G. Bem

Subject: [PATCH] usb: whci: fhci: remove comparison to bool

Get rid of bool explicit comparisons.

Caught by Coccinelle.

Signed-off-by: Geyslan G. Bem <[email protected]>
---
drivers/usb/host/fhci-tds.c | 2 +-
drivers/usb/host/whci/qset.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c
index 1498061..f82ad5d 100644
--- a/drivers/usb/host/fhci-tds.c
+++ b/drivers/usb/host/fhci-tds.c
@@ -85,7 +85,7 @@ static struct usb_td __iomem *next_bd(struct usb_td __iomem *base,

void fhci_push_dummy_bd(struct endpoint *ep)
{
- if (ep->already_pushed_dummy_bd == false) {
+ if (!ep->already_pushed_dummy_bd) {
u16 td_status = in_be16(&ep->empty_td->status);

out_be32(&ep->empty_td->buf_ptr, DUMMY_BD_BUFFER);
diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c
index 3297473..5e48a60 100644
--- a/drivers/usb/host/whci/qset.c
+++ b/drivers/usb/host/whci/qset.c
@@ -395,7 +395,7 @@ static void urb_dequeue_work(struct work_struct *work)
struct whc *whc = qset->whc;
unsigned long flags;

- if (wurb->is_async == true)
+ if (wurb->is_async)
asl_update(whc, WUSBCMD_ASYNC_UPDATED
| WUSBCMD_ASYNC_SYNCED_DB
| WUSBCMD_ASYNC_QSET_RM);
--
2.6.3

2015-12-07 10:09:36

by Peter Senna Tschudin

Subject: Re: [PATCH] usb: whci: fhci: remove comparison to bool

On Wed, Dec 2, 2015 at 10:45 PM, Geyslan G. Bem <[email protected]> wrote:
> Get rid of bool explicit comparisons.
>
> Caught by Coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin <[email protected]>

>
> Signed-off-by: Geyslan G. Bem <[email protected]>
> ---
> drivers/usb/host/fhci-tds.c | 2 +-
> drivers/usb/host/whci/qset.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c
> index 1498061..f82ad5d 100644
> --- a/drivers/usb/host/fhci-tds.c
> +++ b/drivers/usb/host/fhci-tds.c
> @@ -85,7 +85,7 @@ static struct usb_td __iomem *next_bd(struct usb_td __iomem *base,
>
> void fhci_push_dummy_bd(struct endpoint *ep)
> {
> - if (ep->already_pushed_dummy_bd == false) {
> + if (!ep->already_pushed_dummy_bd) {
> u16 td_status = in_be16(&ep->empty_td->status);
>
> out_be32(&ep->empty_td->buf_ptr, DUMMY_BD_BUFFER);
> diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c
> index 3297473..5e48a60 100644
> --- a/drivers/usb/host/whci/qset.c
> +++ b/drivers/usb/host/whci/qset.c
> @@ -395,7 +395,7 @@ static void urb_dequeue_work(struct work_struct *work)
> struct whc *whc = qset->whc;
> unsigned long flags;
>
> - if (wurb->is_async == true)
> + if (wurb->is_async)
> asl_update(whc, WUSBCMD_ASYNC_UPDATED
> | WUSBCMD_ASYNC_SYNCED_DB
> | WUSBCMD_ASYNC_QSET_RM);
> --
> 2.6.3
>



--
Peter