2015-12-06 10:29:14

by Zhaoxiu Zeng

Subject: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])"

From: Zeng Zhaoxiu <[email protected]>

Signed-off-by: Zeng Zhaoxiu <[email protected]>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 9461a23..16c8cf1 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -27,6 +27,7 @@
*
*/

+#include <linux/log2.h>
#include <drm/drmP.h>
#include "i915_drv.h"
#include <drm/i915_drm.h>
@@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring)
* Only consider slices where one, and only one, subslice has 7
* EUs
*/
- if (hweight8(dev_priv->info.subslice_7eu[i]) != 1)
+ if (!is_power_of_2(dev_priv->info.subslice_7eu[i]))
continue;

/*
--
2.5.0

2015-12-07 07:45:54

by Daniel Vetter

Subject: Re: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])"

On Sun, Dec 06, 2015 at 06:26:30PM +0800, Zhaoxiu Zeng wrote:
> From: Zeng Zhaoxiu <[email protected]>
>
> Signed-off-by: Zeng Zhaoxiu <[email protected]>

Queued for -next, thanks for the patch.
-Daniel

> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 9461a23..16c8cf1 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -27,6 +27,7 @@
> *
> */
>
> +#include <linux/log2.h>
> #include <drm/drmP.h>
> #include "i915_drv.h"
> #include <drm/i915_drm.h>
> @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring)
> * Only consider slices where one, and only one, subslice has 7
> * EUs
> */
> - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1)
> + if (!is_power_of_2(dev_priv->info.subslice_7eu[i]))
> continue;
>
> /*
> --
> 2.5.0
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2015-12-07 08:33:48

by Jani Nikula

Subject: Re: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])"

On Sun, 06 Dec 2015, Zhaoxiu Zeng <[email protected]> wrote:
> From: Zeng Zhaoxiu <[email protected]>
>
> Signed-off-by: Zeng Zhaoxiu <[email protected]>

I'd like to see a commit message describing what is done and why, even
for trivial changes. Now the subject line is essentially the diff in
plain English, which adds no information to the patch itself.

It doesn't even say that this should be a non-functional change.

BR,
Jani.


> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 9461a23..16c8cf1 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -27,6 +27,7 @@
> *
> */
>
> +#include <linux/log2.h>
> #include <drm/drmP.h>
> #include "i915_drv.h"
> #include <drm/i915_drm.h>
> @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring)
> * Only consider slices where one, and only one, subslice has 7
> * EUs
> */
> - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1)
> + if (!is_power_of_2(dev_priv->info.subslice_7eu[i]))
> continue;
>
> /*

--
Jani Nikula, Intel Open Source Technology Center