2015-12-08 10:12:05

by Qais Yousef

Subject: [PATCH] MIPS: VDSO: Fix build error

Commit ebb5e78cc634 (MIPS: Initial implementation of a VDSO) introduced a build
error.

For MIPS VDSO to be compiled it requires binutils version 2.25 or above but the
check in the Makefile had inverted logic causing it to be compiled in if binutils
is below 2.25.

This fixes the following compilation error:

CC arch/mips/vdso/gettimeofday.o
/tmp/ccsExcUd.s: Assembler messages:
/tmp/ccsExcUd.s:62: Error: can't resolve `_start' {*UND* section} - `L0' {.text section}
/tmp/ccsExcUd.s:467: Error: can't resolve `_start' {*UND* section} - `L0' {.text section}
make[2]: *** [arch/mips/vdso/gettimeofday.o] Error 1
make[1]: *** [arch/mips/vdso] Error 2
make: *** [arch/mips] Error 2

Signed-off-by: Qais Yousef <[email protected]>
---
arch/mips/vdso/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index ef5f348f386a..018f8c7b94f2 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -26,8 +26,8 @@ aflags-vdso := $(ccflags-vdso) \
# the comments on that file.
#
ifndef CONFIG_CPU_MIPSR6
- ifeq ($(call ld-ifversion, -gt, 22400000, y),)
- $(warning MIPS VDSO requires binutils > 2.24)
+ ifeq ($(call ld-ifversion, -lt, 22500000, y),)
+ $(warning MIPS VDSO requires binutils >= 2.25)
obj-vdso-y := $(filter-out gettimeofday.o, $(obj-vdso-y))
ccflags-vdso += -DDISABLE_MIPS_VDSO
endif
--
2.1.0

2015-12-08 12:10:32

by Sergei Shtylyov

Subject: Re: [PATCH] MIPS: VDSO: Fix build error

Hello.

On 12/8/2015 1:11 PM, Qais Yousef wrote:

> Commit ebb5e78cc634 (MIPS: Initial implementation of a VDSO) introduced a build
> error.

scripts/checkpatch.pl now enforces certain format for the commit citing --
you also need to enclose the summary in "".

> For MIPS VDSO to be compiled it requires binutils version 2.25 or above but the
> check in the Makefile had inverted logic causing it to be compiled in if binutils
> is below 2.25.
>
> This fixes the following compilation error:
>
> CC arch/mips/vdso/gettimeofday.o
> /tmp/ccsExcUd.s: Assembler messages:
> /tmp/ccsExcUd.s:62: Error: can't resolve `_start' {*UND* section} - `L0' {.text section}
> /tmp/ccsExcUd.s:467: Error: can't resolve `_start' {*UND* section} - `L0' {.text section}
> make[2]: *** [arch/mips/vdso/gettimeofday.o] Error 1
> make[1]: *** [arch/mips/vdso] Error 2
> make: *** [arch/mips] Error 2
>
> Signed-off-by: Qais Yousef <[email protected]>
[...]

MBR, Sergei