2015-12-29 22:24:22

by Heinrich Schuchardt

[permalink] [raw]
Subject: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

IOCTL SIOCRTMSG does nothing but return EINVAL.

So comment it as unused.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
include/uapi/linux/sockios.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
index e888b1a..8e7890b 100644
--- a/include/uapi/linux/sockios.h
+++ b/include/uapi/linux/sockios.h
@@ -27,7 +27,7 @@
/* Routing table calls. */
#define SIOCADDRT 0x890B /* add routing table entry */
#define SIOCDELRT 0x890C /* delete routing table entry */
-#define SIOCRTMSG 0x890D /* call to routing system */
+#define SIOCRTMSG 0x890D /* unused */

/* Socket configuration controls. */
#define SIOCGIFNAME 0x8910 /* get iface name */
--
2.1.4


Subject: Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

Hi Heinrich,

On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote:
> IOCTL SIOCRTMSG does nothing but return EINVAL.
>
> So comment it as unused.

Can you say something about how you confirmed this?
It's not immediately obvious from the code.

Cheers,

Michael


> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
> include/uapi/linux/sockios.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
> index e888b1a..8e7890b 100644
> --- a/include/uapi/linux/sockios.h
> +++ b/include/uapi/linux/sockios.h
> @@ -27,7 +27,7 @@
> /* Routing table calls. */
> #define SIOCADDRT 0x890B /* add routing table entry */
> #define SIOCDELRT 0x890C /* delete routing table entry */
> -#define SIOCRTMSG 0x890D /* call to routing system */
> +#define SIOCRTMSG 0x890D /* unused */
>
> /* Socket configuration controls. */
> #define SIOCGIFNAME 0x8910 /* get iface name */
>


--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

2015-12-30 11:15:11

by Heinrich Schuchardt

[permalink] [raw]
Subject: Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote:
> Hi Heinrich,
>
> On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote:
>> IOCTL SIOCRTMSG does nothing but return EINVAL.
>>
>> So comment it as unused.
>
> Can you say something about how you confirmed this?
> It's not immediately obvious from the code.
>
> Cheers,
>
> Michael

grep -GHrn SIOCRTMSG

SIOCRTMSG is only used in:
* net/ipv4/af_inet.c
* include/uapi/linux/sockios.h

inet_ioctl calls ip_rt_ioctl.

ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
otherwise.

cf.
http://lkml.iu.edu/hypermail/linux/kernel/0911.0/02636.html

Best regards

Heinrich

>
>
>> Signed-off-by: Heinrich Schuchardt <[email protected]>
>> ---
>> include/uapi/linux/sockios.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
>> index e888b1a..8e7890b 100644
>> --- a/include/uapi/linux/sockios.h
>> +++ b/include/uapi/linux/sockios.h
>> @@ -27,7 +27,7 @@
>> /* Routing table calls. */
>> #define SIOCADDRT 0x890B /* add routing table entry */
>> #define SIOCDELRT 0x890C /* delete routing table entry */
>> -#define SIOCRTMSG 0x890D /* call to routing system */
>> +#define SIOCRTMSG 0x890D /* unused */
>>
>> /* Socket configuration controls. */
>> #define SIOCGIFNAME 0x8910 /* get iface name */
>>
>
>