2016-03-03 08:14:04

by Krzysztof Kozlowski

Subject: [PATCH] goldfish: Fix build error of missing ioremap on UM

Add missing HAS_IOMEM dependency to fix the allyesconfig build error on
ARCH=um (for x86_64):

drivers/platform/goldfish/pdev_bus.c: In function ‘goldfish_pdev_bus_probe’:
drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len);

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/platform/goldfish/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
index 50331e3e54f3..fefbb8370da0 100644
--- a/drivers/platform/goldfish/Kconfig
+++ b/drivers/platform/goldfish/Kconfig
@@ -1,6 +1,7 @@
menuconfig GOLDFISH
bool "Platform support for Goldfish virtual devices"
depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
+ depends on HAS_IOMEM
---help---
Say Y here to get to see options for the Goldfish virtual platform.
This option alone does not add any kernel code.
--
2.5.0

2016-03-04 15:49:19

by Alan

Subject: Re: [PATCH] goldfish: Fix build error of missing ioremap on UM

On Thu, 2016-03-03 at 17:13 +0900, Krzysztof Kozlowski wrote:
> Add missing HAS_IOMEM dependency to fix the allyesconfig build error
> on
> ARCH=um (for x86_64):
>
> drivers/platform/goldfish/pdev_bus.c: In function
> ‘goldfish_pdev_bus_probe’:
> drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit
> declaration of function ‘ioremap’ [-Werror=implicit-function
> -declaration]
> pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len);
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Alan Cox <[email protected]>

Thanks for that - I was trying to work out where that weird 0day
complaint was coming from.

Alan