On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote:
> Am 02.03.2016 7:19 nachm. schrieb Joe Perches <[email protected]>:
> > On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote:
> > > The existing logging macros are fairly large and converting the?
> > > macros to functions make the object code smaller.?
> > Artem and Adrian are the nominal maintainers for ubifs.?
> >
> > Artem last had a sign-off on a ubifs patch 6 months ago and?
> > Adrian's last one was over 3 years ago.?
> >
> > Is there an expected ack/nack/applied handling time for a?
> > ubifs patch like this??
> >
> > Should this patch go to someone else??
> >
> > Should the MAINTAINERS entry for ubifs be changed to orphan??
> No need to panic. I take care of the patch. :)
No worries, I'm calm. ?But if you're taking care of the patch
and not the nominal maintainers, likely the MAINTAINERS entry
should be updated.
Presumably the equivalent ubi patch will be handled in the
same fashion,
For drivers/mtd/ubi, Artem is also a nominal maintainer, but
last signed a patch in 2014.
Likely the MAINTAINERS entry for UBI should be updated too.
Maybe something like:
---
?MAINTAINERS | 4 +---
?1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 81302e4..927557c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11266,8 +11266,7 @@ S: Maintained
?F: drivers/scsi/u14-34f.c
?
?UBI FILE SYSTEM (UBIFS)
-M: Artem Bityutskiy <[email protected]>
-M: Adrian Hunter <[email protected]>
+M: Richard Weinberger <[email protected]>
?L: [email protected]
?T: git git://git.infradead.org/ubifs-2.6.git
?W: http://www.linux-mtd.infradead.org/doc/ubifs.html
@@ -11350,7 +11349,6 @@ F: Documentation/scsi/ufs.txt
?F: drivers/scsi/ufs/
?
?UNSORTED BLOCK IMAGES (UBI)
-M: Artem Bityutskiy <[email protected]>
?M: Richard Weinberger <[email protected]>
?W: http://www.linux-mtd.infradead.org/
?L: [email protected]
Joe,
Am 02.03.2016 um 19:58 schrieb Joe Perches:
> On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote:
>> Am 02.03.2016 7:19 nachm. schrieb Joe Perches <[email protected]>:
>>> On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote:
>>>> The existing logging macros are fairly large and converting the
>>>> macros to functions make the object code smaller.
>>> Artem and Adrian are the nominal maintainers for ubifs.
>>>
>>> Artem last had a sign-off on a ubifs patch 6 months ago and
>>> Adrian's last one was over 3 years ago.
>>>
>>> Is there an expected ack/nack/applied handling time for a
>>> ubifs patch like this?
>>>
>>> Should this patch go to someone else?
>>>
>>> Should the MAINTAINERS entry for ubifs be changed to orphan?
>> No need to panic. I take care of the patch. :)
>
> No worries, I'm calm. But if you're taking care of the patch
> and not the nominal maintainers, likely the MAINTAINERS entry
> should be updated.
>
> Presumably the equivalent ubi patch will be handled in the
> same fashion,
>
> For drivers/mtd/ubi, Artem is also a nominal maintainer, but
> last signed a patch in 2014.
>
> Likely the MAINTAINERS entry for UBI should be updated too.
>
> Maybe something like:
> ---
> MAINTAINERS | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 81302e4..927557c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11266,8 +11266,7 @@ S: Maintained
> F: drivers/scsi/u14-34f.c
>
> UBI FILE SYSTEM (UBIFS)
> -M: Artem Bityutskiy <[email protected]>
> -M: Adrian Hunter <[email protected]>
> +M: Richard Weinberger <[email protected]>
I can be the official patch monkey for UBIFS.
Especial as the git tree is the same as for UBI.
But I definitely want to keep Artem.
He gives very valuable input and knows UBIFS much better than I do.
> L: [email protected]
> T: git git://git.infradead.org/ubifs-2.6.git
> W: http://www.linux-mtd.infradead.org/doc/ubifs.html
> @@ -11350,7 +11349,6 @@ F: Documentation/scsi/ufs.txt
> F: drivers/scsi/ufs/
>
> UNSORTED BLOCK IMAGES (UBI)
> -M: Artem Bityutskiy <[email protected]>
> M: Richard Weinberger <[email protected]>
> W: http://www.linux-mtd.infradead.org/
> L: [email protected]
Same here. Artem has to stay.
Thanks,
//richard
On Wed, 2016-03-02 at 22:24 +0100, Richard Weinberger wrote:
> Am 02.03.2016 um 19:58 schrieb Joe Perches:
[]
> > For drivers/mtd/ubi, Artem is also a nominal maintainer, but
> > last signed a patch in 2014.
> >
> > Likely the MAINTAINERS entry for UBI should be updated too.
> >
> > Maybe something like:
[]
> > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > @@ -11266,8 +11266,7 @@ S: Maintained
> > ?F: drivers/scsi/u14-34f.c
> > ?
> > ?UBI FILE SYSTEM (UBIFS)
> > -M: Artem Bityutskiy <[email protected]>
> > -M: Adrian Hunter <[email protected]>
> > +M: Richard Weinberger <[email protected]>
> I can be the official patch monkey for UBIFS.
> Especial as the git tree is the same as for UBI.
>
> But I definitely want to keep Artem.
> He gives very valuable input and knows UBIFS much better than I do.
That's fine and it's your (and his) choice what do to.
> > ?L: [email protected]
> > ?T: git git://git.infradead.org/ubifs-2.6.git
> > ?W: http://www.linux-mtd.infradead.org/doc/ubifs.html
> > @@ -11350,7 +11349,6 @@ F: Documentation/scsi/ufs.txt
> > ?F: drivers/scsi/ufs/
> > ?
> > ?UNSORTED BLOCK IMAGES (UBI)
> > -M: Artem Bityutskiy <[email protected]>
> > ?M: Richard Weinberger <[email protected]>
> > ?W: http://www.linux-mtd.infradead.org/
> > ?L: [email protected]
> Same here. Artem has to stay.
Perhaps an "R:" (reviewer) entry is appropriate for Artem.
On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote:
>
> UBI FILE SYSTEM (UBIFS)
> -M: Artem Bityutskiy <[email protected]>
> -M: Adrian Hunter <[email protected]>
> +M: Richard Weinberger <[email protected]>
> L: [email protected]
> T: git git://git.infradead.org/ubifs-2.6.git
> W: http://www.linux-mtd.infradead.org/doc/ubifs.html
Hi Joe,
could please, re-send this patch with the following modifications:
1. Put Richard's name first.
2. Do not remove mine and Adrian's name. We are not very active, but
still useful.
Thanks!
On Thu, 2016-03-03 at 10:39 +0200, Artem Bityutskiy wrote:
> On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote:
> >
> > ?
> > ?UBI FILE SYSTEM (UBIFS)
> > -M: Artem Bityutskiy <[email protected]>
> > -M: Adrian Hunter <[email protected]>
> > +M: Richard Weinberger <[email protected]>
> > ?L: [email protected]
> > ?T: git git://git.infradead.org/ubifs-2.6.git
> > ?W: http://www.linux-mtd.infradead.org/doc/ubifs.html
> Hi Joe,
>
> could please, re-send this patch with the following modifications:
>
> 1. Put Richard's name first.
> 2. Do not remove mine and Adrian's name. We are not very active, but
> still useful.
>
> Thanks!
Hello Artem.
It's not really for me to change Richard's maintainership.
It should be his sign-off, not mine.
My suggestion would be to add him and designate you and Adrian
as R: reviewers instead of M: maintainers like below.
---
?MAINTAINERS | 7 ++++---
?1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 81302e4..61e17a6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11266,8 +11266,9 @@ S: Maintained
?F: drivers/scsi/u14-34f.c
?
?UBI FILE SYSTEM (UBIFS)
-M: Artem Bityutskiy <[email protected]>
-M: Adrian Hunter <[email protected]>
+M: Richard Weinberger <[email protected]>
+R: Artem Bityutskiy <[email protected]>
+R: Adrian Hunter <[email protected]>
?L: [email protected]
?T: git git://git.infradead.org/ubifs-2.6.git
?W: http://www.linux-mtd.infradead.org/doc/ubifs.html
@@ -11350,8 +11351,8 @@ F: Documentation/scsi/ufs.txt
?F: drivers/scsi/ufs/
?
?UNSORTED BLOCK IMAGES (UBI)
-M: Artem Bityutskiy <[email protected]>
?M: Richard Weinberger <[email protected]>
+R: Artem Bityutskiy <[email protected]>
?W: http://www.linux-mtd.infradead.org/
?L: [email protected]
?T: git git://git.infradead.org/ubifs-2.6.git
On Thu, 2016-03-03 at 04:25 -0800, Joe Perches wrote:
> My suggestion would be to add him and designate you and Adrian
> as R: reviewers instead of M: maintainers like below.
I think it is a little bit too early.