2016-03-04 16:28:13

by Wenwei Tao

Subject: [PATCH] null_blk: add lightnvm null_blk device to the nullb_list

After register null_blk devices into lightnvm, we forget
to add these devices to the the nullb_list, makes them
invisible to the null_blk driver.

Signed-off-by: Wenwei Tao <[email protected]>
---
drivers/block/null_blk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index 64a7b59..cab9759 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -742,10 +742,11 @@ static int null_add_dev(void)

add_disk(disk);

+done:
mutex_lock(&lock);
list_add_tail(&nullb->list, &nullb_list);
mutex_unlock(&lock);
-done:
+
return 0;

out_cleanup_lightnvm:
--
1.8.3.1

2016-03-04 16:35:10

by Jens Axboe

Subject: Re: [PATCH] null_blk: add lightnvm null_blk device to the nullb_list

On 03/04/2016 09:27 AM, Wenwei Tao wrote:
> After register null_blk devices into lightnvm, we forget
> to add these devices to the the nullb_list, makes them
> invisible to the null_blk driver.
>
> Signed-off-by: Wenwei Tao <[email protected]>
> ---
> drivers/block/null_blk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
> index 64a7b59..cab9759 100644
> --- a/drivers/block/null_blk.c
> +++ b/drivers/block/null_blk.c
> @@ -742,10 +742,11 @@ static int null_add_dev(void)
>
> add_disk(disk);
>
> +done:
> mutex_lock(&lock);
> list_add_tail(&nullb->list, &nullb_list);
> mutex_unlock(&lock);
> -done:
> +
> return 0;
>
> out_cleanup_lightnvm:

Thanks, that looks like a regression caused by a514379b0c77, I'll add a
Fixes tag.

--
Jens Axboe