2016-03-07 19:30:22

by Nicolai Stange

Subject: [PATCH] arch/microblaze: export isa_io_base to modules

As discovered by the kbuild test robot, an allmodconfig build on
microblaze bails out with

ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined!
[... plus dozens more throughout the tree]

Export isa_io_base to modules by means of EXPORT_SYMBOL().

Signed-off-by: Nicolai Stange <[email protected]>
---
arch/microblaze/pci/pci-common.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
index ae838ed..fba7a46 100644
--- a/arch/microblaze/pci/pci-common.c
+++ b/arch/microblaze/pci/pci-common.c
@@ -48,6 +48,8 @@ static int global_phb_number; /* Global phb counter */
resource_size_t isa_mem_base;

unsigned long isa_io_base;
+EXPORT_SYMBOL(isa_io_base);
+
static int pci_bus_count;

struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
--
2.7.2

2016-03-07 20:32:31

by Bjorn Helgaas

Subject: Re: [PATCH] arch/microblaze: export isa_io_base to modules

On Mon, Mar 07, 2016 at 08:29:24PM +0100, Nicolai Stange wrote:
> As discovered by the kbuild test robot, an allmodconfig build on
> microblaze bails out with
>
> ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
> ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined!
> [... plus dozens more throughout the tree]
>
> Export isa_io_base to modules by means of EXPORT_SYMBOL().
>
> Signed-off-by: Nicolai Stange <[email protected]>

Acked-by: Bjorn Helgaas <[email protected]>

Michal, this was sent to you, so I assume you'll handle it. Let me
know if you want me to do anything else with it.

> ---
> arch/microblaze/pci/pci-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
> index ae838ed..fba7a46 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -48,6 +48,8 @@ static int global_phb_number; /* Global phb counter */
> resource_size_t isa_mem_base;
>
> unsigned long isa_io_base;
> +EXPORT_SYMBOL(isa_io_base);
> +
> static int pci_bus_count;
>
> struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
> --
> 2.7.2
>