2016-03-12 23:45:07

by Nicolas Saenz Julienne

Subject: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

Signed-off-by: Nicolas Saenz Julienne <[email protected]>
---
drivers/usb/class/cdc-acm.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index fa4e239..9831607 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
{ USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
},
+ { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
+ .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
+ },
{ USB_DEVICE(0x0ace, 0x1602), /* ZyDAS 56K USB MODEM */
.driver_info = SINGLE_RX_URB,
},
--
2.5.0

2016-03-13 00:11:27

by Bo YU

Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
I think that you should add something in here.Describe your change or
imporvment.
>Signed-off-by: Nicolas Saenz Julienne <[email protected]>
>---
> drivers/usb/class/cdc-acm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
>index fa4e239..9831607 100644
>--- a/drivers/usb/class/cdc-acm.c
>+++ b/drivers/usb/class/cdc-acm.c
>@@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> },
>+ { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
>+ .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
>+ },
> { USB_DEVICE(0x0ace, 0x1602), /* ZyDAS 56K USB MODEM */
> .driver_info = SINGLE_RX_URB,
> },
>--
>2.5.0
>

2016-03-13 00:44:59

by Greg Kroah-Hartman

Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> ---
> drivers/usb/class/cdc-acm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index fa4e239..9831607 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> },
> + { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> + .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> + },

Why is this needed? Does the descriptors not properly set the class
device?

thanks,

greg k-h

2016-03-15 00:04:39

by Nicolas Saenz Julienne

Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Sat, Mar 12, 2016 at 04:27:29PM -0800, Greg KH wrote:
> On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> > Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> > ---
> > drivers/usb/class/cdc-acm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index fa4e239..9831607 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> > { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> > .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > },
> > + { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> > + .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > + },
>
> Why is this needed? Does the descriptors not properly set the class
> device?
>
> thanks,
>
> greg k-h

Hi,
the device is missing all the ACM specific "extra" info on it's interface
descriptor. Which seems be triggering the "Zero length descriptor references"
error during the probe function. Adding the NO_UNION_NORMAL quirk seems to solve
the issue.
As for the class device, it seems to be ok, CDC (0x2).

Nicolas

2016-03-15 08:51:08

by Oliver Neukum

Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Tue, 2016-03-15 at 00:04 +0000, Nicolas Saenz Julienne wrote:

> Hi,
> the device is missing all the ACM specific "extra" info on it's interface
> descriptor. Which seems be triggering the "Zero length descriptor references"
> error during the probe function. Adding the NO_UNION_NORMAL quirk seems to solve
> the issue.

Could you resubmit with this explanation in the change log?
Then everything will be on record. The patch itself is fine.

Regards
Oliver