2016-03-19 18:36:05

by Parth Sane

Subject: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

Fixed alignment of paranthesis as per checkpatch.

Signed-off-by: Parth Sane <[email protected]>

---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index daee1b2..82af021 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
ndata1.phy_addr[mac] = mac + 4 + 0x10;

- xlr_resource_init(&xlr_net1_res[mac * 2],
- xlr_gmac_offsets[mac + 4],
- xlr_gmac_irqs[mac + 4]);
+ xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);
}
xlr_net_dev1.num_resources = 8;

--
1.9.1

2016-03-19 19:37:16

by Joe Perches

Subject: Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

On Sat, 2016-03-19 at 18:35 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
> ? ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
> ? ndata1.phy_addr[mac] = mac + 4 + 0x10;
> ?
> - xlr_resource_init(&xlr_net1_res[mac * 2],
> - xlr_gmac_offsets[mac + 4],
> - xlr_gmac_irqs[mac + 4]);
> + xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);

More typical is to avoid exceeding 80 columns
and wrap this line like:

xlr_resource_init(&xlr_net1_res[mac * 2],
xlr_gmac_offsets[mac + 4],
xlr_gmac_irqs[mac + 4]);

Indenting the 2nd and 3rd lines with 4 tabs and 2 spaces