This patch updates the device-tree binding doc for
adding support for AXI DMA.
Signed-off-by: Kedareswara rao Appana <[email protected]>
---
Changes for v2:
---> Modified commit message as suggested by Vinod.
---> Moved the patch to forward in the series as suggested by vinod.
.../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index a86737c..5841421 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
@@ -3,8 +3,13 @@ It can be configured to have one channel or two channels. If configured
as two channels, one is to transmit to the video device and another is
to receive from the video device.
+Xilinx AXI DMA engine, it does transfers between memory and AXI4 stream
+target devices. It can be configured to have one channel or two channels.
+If configured as two channels, one is to transmit to the device and another
+is to receive from the device.
+
Required properties:
-- compatible: Should be "xlnx,axi-vdma-1.00.a"
+- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
- #dma-cells: Should be <1>, see "dmas" property below
- reg: Should contain VDMA registers location and length.
- xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
@@ -59,6 +64,21 @@ axi_vdma_0: axivdma@40030000 {
} ;
} ;
+axi_dma_0: axidma@40400000 {
+ compatible = "xlnx,axi-dma-1.00.a";
+ #dma-cells = <1>;
+ reg = < 0x40400000 0x10000 >;
+ dma-channel@40400000 {
+ compatible = "xlnx,axi-dma-mm2s-channel";
+ interrupts = < 0 59 4 >;
+ xlnx,datawidth = <0x40>;
+ } ;
+ dma-channel@40400030 {
+ compatible = "xlnx,axi-dma-s2mm-channel";
+ interrupts = < 0 58 4 >;
+ xlnx,datawidth = <0x40>;
+ } ;
+} ;
* DMA client
--
2.1.2
This patch updates the device-tree binding doc for
adding support for AXI CDMA.
Signed-off-by: Kedareswara rao Appana <[email protected]>
---
---> Modified commit message as suggested by Vinod.
---> Moved the patch to forward in the series as suggested by vinod.
.../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index 5841421..2b0c12b 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
@@ -8,8 +8,12 @@ target devices. It can be configured to have one channel or two channels.
If configured as two channels, one is to transmit to the device and another
is to receive from the device.
+Xilinx AXI CDMA engine, it does transfers between memory-mapped source
+address and a memory-mapped destination address.
+
Required properties:
-- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
+- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
+ "xlnx,axi-cdma-1.00.a""
- #dma-cells: Should be <1>, see "dmas" property below
- reg: Should contain VDMA registers location and length.
- xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
@@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
} ;
} ;
+axi_cdma_0: axicdma@7e200000 {
+ compatible = "xlnx,axi-cdma-1.00.a";
+ #dma-cells = <1>;
+ reg = < 0x7e200000 0x10000 >;
+ xlnx,addrwidth = <0x20>;
+ dma-channel@7e200000 {
+ compatible = "xlnx,axi-dma-mm2s-channel";
+ interrupts = < 0 55 4 >;
+ xlnx,datawidth = <0x40>;
+ } ;
+} ;
+
* DMA client
Required properties:
--
2.1.2
On Sun, 2016-03-27 at 23:36:05 +0530, Kedareswara rao Appana wrote:
> This patch updates the device-tree binding doc for
> adding support for AXI DMA.
>
> Signed-off-by: Kedareswara rao Appana <[email protected]>
> ---
> Changes for v2:
> ---> Modified commit message as suggested by Vinod.
> ---> Moved the patch to forward in the series as suggested by vinod.
>
> .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> index a86737c..5841421 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> @@ -3,8 +3,13 @@ It can be configured to have one channel or two channels. If configured
> as two channels, one is to transmit to the video device and another is
> to receive from the video device.
>
> +Xilinx AXI DMA engine, it does transfers between memory and AXI4 stream
> +target devices. It can be configured to have one channel or two channels.
> +If configured as two channels, one is to transmit to the device and another
> +is to receive from the device.
> +
> Required properties:
> -- compatible: Should be "xlnx,axi-vdma-1.00.a"
> +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> - #dma-cells: Should be <1>, see "dmas" property below
> - reg: Should contain VDMA registers location and length.
> - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
> @@ -59,6 +64,21 @@ axi_vdma_0: axivdma@40030000 {
> } ;
> } ;
>
> +axi_dma_0: axidma@40400000 {
The node names should follow the generic names, hence
'dma-controller@...'.
> + compatible = "xlnx,axi-dma-1.00.a";
> + #dma-cells = <1>;
> + reg = < 0x40400000 0x10000 >;
> + dma-channel@40400000 {
> + compatible = "xlnx,axi-dma-mm2s-channel";
> + interrupts = < 0 59 4 >;
> + xlnx,datawidth = <0x40>;
> + } ;
> + dma-channel@40400030 {
> + compatible = "xlnx,axi-dma-s2mm-channel";
> + interrupts = < 0 58 4 >;
> + xlnx,datawidth = <0x40>;
Nit: The spacing around the '<' '>' is inconsistent. I'd just remove all
redundant spaces.
Sören
On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> This patch updates the device-tree binding doc for
> adding support for AXI CDMA.
>
> Signed-off-by: Kedareswara rao Appana <[email protected]>
> ---
> ---> Modified commit message as suggested by Vinod.
> ---> Moved the patch to forward in the series as suggested by vinod.
>
> .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> index 5841421..2b0c12b 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel or two channels.
> If configured as two channels, one is to transmit to the device and another
> is to receive from the device.
>
> +Xilinx AXI CDMA engine, it does transfers between memory-mapped source
> +address and a memory-mapped destination address.
> +
> Required properties:
> -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> + "xlnx,axi-cdma-1.00.a""
> - #dma-cells: Should be <1>, see "dmas" property below
> - reg: Should contain VDMA registers location and length.
> - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
> @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> } ;
> } ;
>
> +axi_cdma_0: axicdma@7e200000 {
> + compatible = "xlnx,axi-cdma-1.00.a";
> + #dma-cells = <1>;
> + reg = < 0x7e200000 0x10000 >;
> + xlnx,addrwidth = <0x20>;
> + dma-channel@7e200000 {
> + compatible = "xlnx,axi-dma-mm2s-channel";
> + interrupts = < 0 55 4 >;
> + xlnx,datawidth = <0x40>;
> + } ;
> +} ;
As in the other patch, the node name should be 'dma-controller@...' and
the inconsistend spacing could be fixed.
Also, it seems this adds pretty much identical examples that just differ
in the compat string. Is that really needed?
Sören
Hi Soren,
> -----Original Message-----
> From: Sören Brinkmann [mailto:[email protected]]
> Sent: Monday, March 28, 2016 12:58 AM
> To: Appana Durga Kedareswara Rao
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Michal Simek;
> [email protected]; [email protected]; Anurag Kumar Vulisha; Appana
> Durga Kedareswara Rao; [email protected];
> [email protected]; [email protected]; Srikanth
> Vemula; Anirudha Sarangi; [email protected]; linux-arm-
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> AXI CDMA
>
> On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > This patch updates the device-tree binding doc for adding support for
> > AXI CDMA.
> >
> > Signed-off-by: Kedareswara rao Appana <[email protected]>
> > ---
> > ---> Modified commit message as suggested by Vinod.
> > ---> Moved the patch to forward in the series as suggested by vinod.
> >
> > .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 18
> +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > index 5841421..2b0c12b 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel
> or two channels.
> > If configured as two channels, one is to transmit to the device and
> > another is to receive from the device.
> >
> > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > +source address and a memory-mapped destination address.
> > +
> > Required properties:
> > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> > + "xlnx,axi-cdma-1.00.a""
> > - #dma-cells: Should be <1>, see "dmas" property below
> > - reg: Should contain VDMA registers location and length.
> > - xlnx,num-fstores: Should be the number of framebuffers as configured in
> h/w.
> > @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> > } ;
> > } ;
> >
> > +axi_cdma_0: axicdma@7e200000 {
> > + compatible = "xlnx,axi-cdma-1.00.a";
> > + #dma-cells = <1>;
> > + reg = < 0x7e200000 0x10000 >;
> > + xlnx,addrwidth = <0x20>;
> > + dma-channel@7e200000 {
> > + compatible = "xlnx,axi-dma-mm2s-channel";
> > + interrupts = < 0 55 4 >;
> > + xlnx,datawidth = <0x40>;
> > + } ;
> > +} ;
>
> As in the other patch, the node name should be 'dma-controller@...' and the
> inconsistend spacing could be fixed.
Ok will fix...
>
> Also, it seems this adds pretty much identical examples that just differ in the
> compat string. Is that really needed?
Most of the properties are same across the three DMA's
For AXI VDMA there are few required properties that are not required for AXI DMA/CDMA.
That's why added example for the other IP's as well I mean for AXI DMA and CDMA.
Regards,
Kedar.
>
> Sören
Hi Soren,
> -----Original Message-----
> From: Sören Brinkmann [mailto:[email protected]]
> Sent: Monday, March 28, 2016 12:56 AM
> To: Appana Durga Kedareswara Rao
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Michal Simek;
> [email protected]; [email protected]; Anurag Kumar Vulisha; Appana
> Durga Kedareswara Rao; [email protected];
> [email protected]; [email protected]; Srikanth
> Vemula; Anirudha Sarangi; [email protected]; linux-arm-
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for
> AXI DMA
>
> On Sun, 2016-03-27 at 23:36:05 +0530, Kedareswara rao Appana wrote:
> > This patch updates the device-tree binding doc for adding support for
> > AXI DMA.
> >
> > Signed-off-by: Kedareswara rao Appana <[email protected]>
> > ---
> > Changes for v2:
> > ---> Modified commit message as suggested by Vinod.
> > ---> Moved the patch to forward in the series as suggested by vinod.
> >
> > .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 22
> > +++++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > index a86737c..5841421 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > @@ -3,8 +3,13 @@ It can be configured to have one channel or two
> > channels. If configured as two channels, one is to transmit to the
> > video device and another is to receive from the video device.
> >
> > +Xilinx AXI DMA engine, it does transfers between memory and AXI4
> > +stream target devices. It can be configured to have one channel or two
> channels.
> > +If configured as two channels, one is to transmit to the device and
> > +another is to receive from the device.
> > +
> > Required properties:
> > -- compatible: Should be "xlnx,axi-vdma-1.00.a"
> > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > - #dma-cells: Should be <1>, see "dmas" property below
> > - reg: Should contain VDMA registers location and length.
> > - xlnx,num-fstores: Should be the number of framebuffers as configured in
> h/w.
> > @@ -59,6 +64,21 @@ axi_vdma_0: axivdma@40030000 {
> > } ;
> > } ;
> >
> > +axi_dma_0: axidma@40400000 {
>
> The node names should follow the generic names, hence 'dma-controller@...'.
Ok will fix in next version...
>
> > + compatible = "xlnx,axi-dma-1.00.a";
> > + #dma-cells = <1>;
> > + reg = < 0x40400000 0x10000 >;
> > + dma-channel@40400000 {
> > + compatible = "xlnx,axi-dma-mm2s-channel";
> > + interrupts = < 0 59 4 >;
> > + xlnx,datawidth = <0x40>;
> > + } ;
> > + dma-channel@40400030 {
> > + compatible = "xlnx,axi-dma-s2mm-channel";
> > + interrupts = < 0 58 4 >;
> > + xlnx,datawidth = <0x40>;
>
> Nit: The spacing around the '<' '>' is inconsistent. I'd just remove all redundant
> spaces.
Ok will fix in next version...
Regards,
Kedar.
>
> Sören
On Sun, Mar 27, 2016 at 11:36:05PM +0530, Kedareswara rao Appana wrote:
> This patch updates the device-tree binding doc for
> adding support for AXI DMA.
>
> Signed-off-by: Kedareswara rao Appana <[email protected]>
> ---
> Changes for v2:
> ---> Modified commit message as suggested by Vinod.
> ---> Moved the patch to forward in the series as suggested by vinod.
>
> .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> index a86737c..5841421 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> @@ -3,8 +3,13 @@ It can be configured to have one channel or two channels. If configured
> as two channels, one is to transmit to the video device and another is
> to receive from the video device.
>
> +Xilinx AXI DMA engine, it does transfers between memory and AXI4 stream
> +target devices. It can be configured to have one channel or two channels.
> +If configured as two channels, one is to transmit to the device and another
> +is to receive from the device.
> +
> Required properties:
> -- compatible: Should be "xlnx,axi-vdma-1.00.a"
> +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
Why the new compatible string? This is 2 different IP blocks? If so, is
there really much shared?
> - #dma-cells: Should be <1>, see "dmas" property below
> - reg: Should contain VDMA registers location and length.
> - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
> @@ -59,6 +64,21 @@ axi_vdma_0: axivdma@40030000 {
> } ;
> } ;
>
> +axi_dma_0: axidma@40400000 {
dma@40400000
> + compatible = "xlnx,axi-dma-1.00.a";
> + #dma-cells = <1>;
> + reg = < 0x40400000 0x10000 >;
> + dma-channel@40400000 {
> + compatible = "xlnx,axi-dma-mm2s-channel";
> + interrupts = < 0 59 4 >;
> + xlnx,datawidth = <0x40>;
> + } ;
> + dma-channel@40400030 {
> + compatible = "xlnx,axi-dma-s2mm-channel";
> + interrupts = < 0 58 4 >;
> + xlnx,datawidth = <0x40>;
> + } ;
> +} ;
>
> * DMA client
>
> --
> 2.1.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Mar 28, 2016 at 05:27:01AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Soren,
>
> > -----Original Message-----
> > From: S?ren Brinkmann [mailto:[email protected]]
> > Sent: Monday, March 28, 2016 12:58 AM
> > To: Appana Durga Kedareswara Rao
> > Cc: [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; Michal Simek;
> > [email protected]; [email protected]; Anurag Kumar Vulisha; Appana
> > Durga Kedareswara Rao; [email protected];
> > [email protected]; [email protected]; Srikanth
> > Vemula; Anirudha Sarangi; [email protected]; linux-arm-
> > [email protected]; [email protected];
> > [email protected]
> > Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> > AXI CDMA
> >
> > On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > > This patch updates the device-tree binding doc for adding support for
> > > AXI CDMA.
> > >
> > > Signed-off-by: Kedareswara rao Appana <[email protected]>
> > > ---
> > > ---> Modified commit message as suggested by Vinod.
> > > ---> Moved the patch to forward in the series as suggested by vinod.
> > >
> > > .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 18
> > +++++++++++++++++-
> > > 1 file changed, 17 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > index 5841421..2b0c12b 100644
> > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel
> > or two channels.
> > > If configured as two channels, one is to transmit to the device and
> > > another is to receive from the device.
> > >
> > > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > > +source address and a memory-mapped destination address.
> > > +
> > > Required properties:
> > > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> > > + "xlnx,axi-cdma-1.00.a""
> > > - #dma-cells: Should be <1>, see "dmas" property below
> > > - reg: Should contain VDMA registers location and length.
> > > - xlnx,num-fstores: Should be the number of framebuffers as configured in
> > h/w.
> > > @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> > > } ;
> > > } ;
> > >
> > > +axi_cdma_0: axicdma@7e200000 {
> > > + compatible = "xlnx,axi-cdma-1.00.a";
> > > + #dma-cells = <1>;
> > > + reg = < 0x7e200000 0x10000 >;
> > > + xlnx,addrwidth = <0x20>;
> > > + dma-channel@7e200000 {
> > > + compatible = "xlnx,axi-dma-mm2s-channel";
> > > + interrupts = < 0 55 4 >;
> > > + xlnx,datawidth = <0x40>;
> > > + } ;
> > > +} ;
> >
> > As in the other patch, the node name should be 'dma-controller@...' and the
> > inconsistend spacing could be fixed.
>
> Ok will fix...
>
> >
> > Also, it seems this adds pretty much identical examples that just differ in the
> > compat string. Is that really needed?
>
> Most of the properties are same across the three DMA's
> For AXI VDMA there are few required properties that are not required for AXI DMA/CDMA.
> That's why added example for the other IP's as well I mean for AXI DMA and CDMA.
It needs to be clear what properties are required/valid for each
compatible string rather than relying on examples. I should be able to
write or validate the examples based on the rest of the text.
Rob
Hi Rob,
> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: Tuesday, March 29, 2016 2:26 AM
> To: Appana Durga Kedareswara Rao
> Cc: Soren Brinkmann; [email protected]; [email protected];
> [email protected]; [email protected]; Michal Simek;
> [email protected]; [email protected]; Anurag Kumar Vulisha;
> [email protected]; [email protected];
> [email protected]; Srikanth Vemula; Anirudha Sarangi;
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> AXI CDMA
>
> On Mon, Mar 28, 2016 at 05:27:01AM +0000, Appana Durga Kedareswara Rao
> wrote:
> > Hi Soren,
> >
> > > -----Original Message-----
> > > From: S?ren Brinkmann [mailto:[email protected]]
> > > Sent: Monday, March 28, 2016 12:58 AM
> > > To: Appana Durga Kedareswara Rao
> > > Cc: [email protected]; [email protected]; [email protected];
> > > [email protected]; [email protected]; Michal Simek;
> > > [email protected]; [email protected]; Anurag Kumar
> > > Vulisha; Appana Durga Kedareswara Rao; [email protected];
> > > [email protected]; [email protected]; Srikanth
> > > Vemula; Anirudha Sarangi; [email protected]; linux-arm-
> > > [email protected]; [email protected];
> > > [email protected]
> > > Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding
> > > doc for AXI CDMA
> > >
> > > On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > > > This patch updates the device-tree binding doc for adding support
> > > > for AXI CDMA.
> > > >
> > > > Signed-off-by: Kedareswara rao Appana <[email protected]>
> > > > ---
> > > > ---> Modified commit message as suggested by Vinod.
> > > > ---> Moved the patch to forward in the series as suggested by vinod.
> > > >
> > > > .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 18
> > > +++++++++++++++++-
> > > > 1 file changed, 17 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > index 5841421..2b0c12b 100644
> > > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > @@ -8,8 +8,12 @@ target devices. It can be configured to have one
> > > > channel
> > > or two channels.
> > > > If configured as two channels, one is to transmit to the device
> > > > and another is to receive from the device.
> > > >
> > > > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > > > +source address and a memory-mapped destination address.
> > > > +
> > > > Required properties:
> > > > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > > > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> or
> > > > + "xlnx,axi-cdma-1.00.a""
> > > > - #dma-cells: Should be <1>, see "dmas" property below
> > > > - reg: Should contain VDMA registers location and length.
> > > > - xlnx,num-fstores: Should be the number of framebuffers as
> > > > configured in
> > > h/w.
> > > > @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> > > > } ;
> > > > } ;
> > > >
> > > > +axi_cdma_0: axicdma@7e200000 {
> > > > + compatible = "xlnx,axi-cdma-1.00.a";
> > > > + #dma-cells = <1>;
> > > > + reg = < 0x7e200000 0x10000 >;
> > > > + xlnx,addrwidth = <0x20>;
> > > > + dma-channel@7e200000 {
> > > > + compatible = "xlnx,axi-dma-mm2s-channel";
> > > > + interrupts = < 0 55 4 >;
> > > > + xlnx,datawidth = <0x40>;
> > > > + } ;
> > > > +} ;
> > >
> > > As in the other patch, the node name should be 'dma-controller@...'
> > > and the inconsistend spacing could be fixed.
> >
> > Ok will fix...
> >
> > >
> > > Also, it seems this adds pretty much identical examples that just
> > > differ in the compat string. Is that really needed?
> >
> > Most of the properties are same across the three DMA's For AXI VDMA
> > there are few required properties that are not required for AXI DMA/CDMA.
> > That's why added example for the other IP's as well I mean for AXI DMA and
> CDMA.
>
> It needs to be clear what properties are required/valid for each compatible
> string rather than relying on examples. I should be able to write or validate the
> examples based on the rest of the text.
Ok will fix it in the next version of the patch.
Regards,
Kedar.
>
> Rob
Hi Rob,
> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: Tuesday, March 29, 2016 2:23 AM
> To: Appana Durga Kedareswara Rao
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Michal Simek; Soren
> Brinkmann; [email protected]; [email protected]; Anurag Kumar
> Vulisha; Appana Durga Kedareswara Rao; [email protected];
> [email protected]; [email protected]; Srikanth
> Vemula; Anirudha Sarangi; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]
> Subject: Re: [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for
> AXI DMA
>
> On Sun, Mar 27, 2016 at 11:36:05PM +0530, Kedareswara rao Appana wrote:
> > This patch updates the device-tree binding doc for adding support for
> > AXI DMA.
> >
> > Signed-off-by: Kedareswara rao Appana <[email protected]>
> > ---
> > Changes for v2:
> > ---> Modified commit message as suggested by Vinod.
> > ---> Moved the patch to forward in the series as suggested by vinod.
> >
> > .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 22
> > +++++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > index a86737c..5841421 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > @@ -3,8 +3,13 @@ It can be configured to have one channel or two
> > channels. If configured as two channels, one is to transmit to the
> > video device and another is to receive from the video device.
> >
> > +Xilinx AXI DMA engine, it does transfers between memory and AXI4
> > +stream target devices. It can be configured to have one channel or two
> channels.
> > +If configured as two channels, one is to transmit to the device and
> > +another is to receive from the device.
> > +
> > Required properties:
> > -- compatible: Should be "xlnx,axi-vdma-1.00.a"
> > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
>
> Why the new compatible string? This is 2 different IP blocks? If so, is there really
> much shared?
The support for the AXI DMA IP also added to the existing VDMA Linux driver
In this series of patches.
>
> > - #dma-cells: Should be <1>, see "dmas" property below
> > - reg: Should contain VDMA registers location and length.
> > - xlnx,num-fstores: Should be the number of framebuffers as configured in
> h/w.
> > @@ -59,6 +64,21 @@ axi_vdma_0: axivdma@40030000 {
> > } ;
> > } ;
> >
> > +axi_dma_0: axidma@40400000 {
>
> dma@40400000
Ok will fix in the next version
Thanks,
Kedar.
>
> > + compatible = "xlnx,axi-dma-1.00.a";
> > + #dma-cells = <1>;
> > + reg = < 0x40400000 0x10000 >;
> > + dma-channel@40400000 {
> > + compatible = "xlnx,axi-dma-mm2s-channel";
> > + interrupts = < 0 59 4 >;
> > + xlnx,datawidth = <0x40>;
> > + } ;
> > + dma-channel@40400030 {
> > + compatible = "xlnx,axi-dma-s2mm-channel";
> > + interrupts = < 0 58 4 >;
> > + xlnx,datawidth = <0x40>;
> > + } ;
> > +} ;
> >
> > * DMA client
> >
> > --
> > 2.1.2
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel