2016-03-31 23:07:57

by Markus Böhme

[permalink] [raw]
Subject: [PATCH] staging/rdma/hfi1: select CRC32

The function parse_platform_config in firmware.c calls crc32_le.
Building without CRC32 selected causes a link error:

drivers/built-in.o: In function `parse_platform_config':
(.text+0x92ffa): undefined reference to `crc32_le'

Signed-off-by: Markus Böhme <[email protected]>
---
drivers/staging/rdma/hfi1/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig
index 3e668d8..a925fb0 100644
--- a/drivers/staging/rdma/hfi1/Kconfig
+++ b/drivers/staging/rdma/hfi1/Kconfig
@@ -2,6 +2,7 @@ config INFINIBAND_HFI1
tristate "Intel OPA Gen1 support"
depends on X86_64 && INFINIBAND_RDMAVT
select MMU_NOTIFIER
+ select CRC32
default m
---help---
This is a low-level driver for Intel OPA Gen1 adapter.
--
1.7.10.4


2016-04-14 17:59:25

by Ira Weiny

[permalink] [raw]
Subject: Re: [PATCH] staging/rdma/hfi1: select CRC32

On Fri, Apr 01, 2016 at 01:04:05AM +0200, Markus B?hme wrote:
> The function parse_platform_config in firmware.c calls crc32_le.
> Building without CRC32 selected causes a link error:
>
> drivers/built-in.o: In function `parse_platform_config':
> (.text+0x92ffa): undefined reference to `crc32_le'
>
> Signed-off-by: Markus B?hme <[email protected]>

Doug did you pick this up?

Reviewed-by: Ira Weiny <[email protected]>

> ---
> drivers/staging/rdma/hfi1/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig
> index 3e668d8..a925fb0 100644
> --- a/drivers/staging/rdma/hfi1/Kconfig
> +++ b/drivers/staging/rdma/hfi1/Kconfig
> @@ -2,6 +2,7 @@ config INFINIBAND_HFI1
> tristate "Intel OPA Gen1 support"
> depends on X86_64 && INFINIBAND_RDMAVT
> select MMU_NOTIFIER
> + select CRC32
> default m
> ---help---
> This is a low-level driver for Intel OPA Gen1 adapter.
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html