2016-04-13 07:40:54

by Pengcheng Li

[permalink] [raw]
Subject: [PATCH] coresight: etm4x: modify q_support type

Because this operation exceed the range of boolean,
so we should modify q_support to unit8 bit.
drvdata->q_support = BMVAL(etmidr0, 15, 16)

Signed-off-by: Li Pengcheng <[email protected]>
Signed-off-by: Li Zhong <[email protected]>
---
drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
index a291d4c..5359c51 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.h
+++ b/drivers/hwtracing/coresight/coresight-etm4x.h
@@ -372,6 +372,7 @@ struct etmv4_drvdata {
u8 ccitmin;
u8 s_ex_level;
u8 ns_ex_level;
+ u8 q_support;
bool sticky_enable;
bool boot_enable;
bool os_unlock;
@@ -380,7 +381,6 @@ struct etmv4_drvdata {
bool trccond;
bool retstack;
bool trccci;
- bool q_support;
bool trc_error;
bool syncpr;
bool stallctl;
--
1.8.3.2


2016-04-13 15:43:28

by Mathieu Poirier

[permalink] [raw]
Subject: Re: [PATCH] coresight: etm4x: modify q_support type

On 13 April 2016 at 01:40, lipengcheng <[email protected]> wrote:
> Because this operation exceed the range of boolean,
> so we should modify q_support to unit8 bit.
> drvdata->q_support = BMVAL(etmidr0, 15, 16)
>
> Signed-off-by: Li Pengcheng <[email protected]>
> Signed-off-by: Li Zhong <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
> index a291d4c..5359c51 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.h
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.h
> @@ -372,6 +372,7 @@ struct etmv4_drvdata {
> u8 ccitmin;
> u8 s_ex_level;
> u8 ns_ex_level;
> + u8 q_support;
> bool sticky_enable;
> bool boot_enable;
> bool os_unlock;
> @@ -380,7 +381,6 @@ struct etmv4_drvdata {
> bool trccond;
> bool retstack;
> bool trccci;
> - bool q_support;
> bool trc_error;
> bool syncpr;
> bool stallctl;

Applied - thanks.
Mathieu

> --
> 1.8.3.2
>