2016-04-15 02:41:35

by Dan Williams

Subject: [PATCH] libnvdimm, btt: add btt startup debug

Report the reason for btt probe failures when debug is enabled.

Signed-off-by: Dan Williams <[email protected]>
---
drivers/nvdimm/btt.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index cc9fafed9362..68a7c3c1eed9 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct nd_namespace_common *ndns)
struct btt *btt;
size_t rawsize;

- if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
+ if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
+ dev_dbg(&nd_btt->dev, "incomplete btt configuration\n");
return -ENODEV;
+ }

rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
if (rawsize < ARENA_MIN_SIZE) {
+ dev_dbg(&nd_btt->dev, "%s must be at least %ld bytes\n",
+ dev_name(&ndns->dev), ARENA_MIN_SIZE + SZ_4K);
return -ENXIO;
}
nd_region = to_nd_region(nd_btt->dev.parent);

2016-04-15 07:10:32

by Johannes Thumshirn

Subject: Re: [PATCH] libnvdimm, btt: add btt startup debug

On Donnerstag, 14. April 2016 19:40:42 CEST Dan Williams wrote:
> Report the reason for btt probe failures when debug is enabled.
>
> Signed-off-by: Dan Williams <[email protected]>

Looks good to me,
Reviewed-by: Johannes Thumshirn <[email protected]>


--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

2016-04-15 17:00:37

by Verma, Vishal L

Subject: Re: [PATCH] libnvdimm, btt: add btt startup debug

On Thu, 2016-04-14 at 19:40 -0700, Dan Williams wrote:
> Report the reason for btt probe failures when debug is enabled.
>
> Signed-off-by: Dan Williams <[email protected]>
> ---
>  drivers/nvdimm/btt.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reveiwed-by: Vishal Verma <[email protected]>

>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index cc9fafed9362..68a7c3c1eed9 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct
> nd_namespace_common *ndns)
>   struct btt *btt;
>   size_t rawsize;
>  
> - if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
> + if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
> + dev_dbg(&nd_btt->dev, "incomplete btt
> configuration\n");
>   return -ENODEV;
> + }
>  
>   rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
>   if (rawsize < ARENA_MIN_SIZE) {
> + dev_dbg(&nd_btt->dev, "%s must be at least %ld
> bytes\n",
> + dev_name(&ndns->dev), ARENA_MIN_SIZE
> + SZ_4K);
>   return -ENXIO;
>   }
>   nd_region = to_nd_region(nd_btt->dev.parent);
>
> _______________________________________________
> Linux-nvdimm mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/linux-nvdimm