2016-10-08 20:42:25

by Scott Branden

[permalink] [raw]
Subject: [PATCH] ARM: multi_v7_defconfig: Enable Intel e1000e driver

Enable support for the Intel e1000e driver

Signed-off-by: Ray Jui <[email protected]>
Signed-off-by: Scott Branden <[email protected]>
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index ea3566f..b88a67a 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -843,6 +843,7 @@ CONFIG_PWM_SUN4I=y
CONFIG_PWM_TEGRA=y
CONFIG_PWM_VT8500=y
CONFIG_PHY_HIX5HD2_SATA=y
+CONFIG_E1000E=y
CONFIG_PWM_STI=y
CONFIG_PWM_BCM2835=y
CONFIG_PWM_BRCMSTB=m
--
2.5.0


2016-10-10 07:56:50

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable Intel e1000e driver

On Saturday, October 8, 2016 1:41:04 PM CEST Scott Branden wrote:
> Enable support for the Intel e1000e driver
>
> Signed-off-by: Ray Jui <[email protected]>
> Signed-off-by: Scott Branden <[email protected]>
>

Can we make this a loadable module and group it with the other
ethernet drivers?

Arnd

2016-10-11 22:38:47

by Scott Branden

[permalink] [raw]
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable Intel e1000e driver

Hi Arnd,

On 16-10-10 12:47 AM, Arnd Bergmann wrote:
> On Saturday, October 8, 2016 1:41:04 PM CEST Scott Branden wrote:
>> Enable support for the Intel e1000e driver
>>
>> Signed-off-by: Ray Jui <[email protected]>
>> Signed-off-by: Scott Branden <[email protected]>
>>
>
> Can we make this a loadable module and group it with the other
> ethernet drivers?
>
We use a fixed rootfs image to test the kernel. For simplicity we don't
construct a rootfs or load any modules. We just test the kernel image.
So for us every defconfig we use needs to be set to y to use the
upstreamed kernel.

Plus, how do you NFS mount a rootfs if the ethernet driver is a loadable
module?
> Arnd
>

Regards,
Scott

2016-10-17 22:04:00

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable Intel e1000e driver

On Tue, Oct 11, 2016 at 3:38 PM, Scott Branden
<[email protected]> wrote:
> Hi Arnd,
>
> On 16-10-10 12:47 AM, Arnd Bergmann wrote:
>>
>> On Saturday, October 8, 2016 1:41:04 PM CEST Scott Branden wrote:
>>>
>>> Enable support for the Intel e1000e driver
>>>
>>> Signed-off-by: Ray Jui <[email protected]>
>>> Signed-off-by: Scott Branden <[email protected]>
>>>
>>
>> Can we make this a loadable module and group it with the other
>> ethernet drivers?
>>
> We use a fixed rootfs image to test the kernel. For simplicity we don't
> construct a rootfs or load any modules. We just test the kernel image. So
> for us every defconfig we use needs to be set to y to use the upstreamed
> kernel.
>
> Plus, how do you NFS mount a rootfs if the ethernet driver is a loadable
> module?

Yeah, agreed that it makes sense to enable it here. Applied to fixes.


-Olof