2016-10-17 16:37:35

by Wei Yongjun

Subject: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

From: Wei Yongjun <[email protected]>

This node pointer is returned by of_find_compatible_node() with
refcount incremented in this function. of_node_put() on it before
exitting this function.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/staging/greybus/arche-platform.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index a850f6b..389ed36 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -128,6 +128,7 @@ int arche_platform_change_state(enum arche_platform_state state,
pdev = of_find_device_by_node(np);
if (!pdev) {
pr_err("arche-platform device not found\n");
+ of_node_put(np);
return -ENODEV;
}

2016-10-17 16:51:26

by Johan Hovold

Subject: Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

On Mon, Oct 17, 2016 at 04:37:20PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> This node pointer is returned by of_find_compatible_node() with
> refcount incremented in this function. of_node_put() on it before
> exitting this function.
>
> This is detected by Coccinelle semantic patch.
>
> Signed-off-by: Wei Yongjun <[email protected]>

This code is going away eventually, but still.

Acked-by: Johan Hovold <[email protected]>

Thanks,
Johan