2016-10-20 07:11:48

by Masahiro Yamada

Subject: [PATCH v3] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus()

These log messages are wrong because _of_get_opp_desc_node() returns
an operating-points-v2 node.

Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed
static checker warnings, and reworded the messages at the same time
(but the latter was not mentioned in the git-log).

Restore the correct messages.

Signed-off-by: Masahiro Yamada <[email protected]>
---

Changes in v3:
- Revive __func__

Changes in v2:
- Reword git-log slightly
comments -> log messages

drivers/base/power/opp/of.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c
index 6480137..5b3755e 100644
--- a/drivers/base/power/opp/of.c
+++ b/drivers/base/power/opp/of.c
@@ -562,7 +562,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
/* Get OPP descriptor node */
np = _of_get_opp_desc_node(cpu_dev);
if (!np) {
- dev_dbg(cpu_dev, "%s: Couldn't find cpu_dev node.\n", __func__);
+ dev_dbg(cpu_dev, "%s: Couldn't find opp node.\n", __func__);
return -ENOENT;
}

@@ -587,7 +587,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
/* Get OPP descriptor node */
tmp_np = _of_get_opp_desc_node(tcpu_dev);
if (!tmp_np) {
- dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n",
+ dev_err(tcpu_dev, "%s: Couldn't find opp node.\n",
__func__);
ret = -ENOENT;
goto put_cpu_node;
--
1.9.1

2016-10-20 07:12:44

by Viresh Kumar

Subject: Re: [PATCH v3] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus()

On 20-10-16, 16:12, Masahiro Yamada wrote:
> These log messages are wrong because _of_get_opp_desc_node() returns
> an operating-points-v2 node.
>
> Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed
> static checker warnings, and reworded the messages at the same time
> (but the latter was not mentioned in the git-log).
>
> Restore the correct messages.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> Changes in v3:
> - Revive __func__
>
> Changes in v2:
> - Reword git-log slightly
> comments -> log messages

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2016-10-20 19:19:03

by Stephen Boyd

Subject: Re: [PATCH v3] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus()

On 10/20, Masahiro Yamada wrote:
> These log messages are wrong because _of_get_opp_desc_node() returns
> an operating-points-v2 node.
>
> Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed
> static checker warnings, and reworded the messages at the same time
> (but the latter was not mentioned in the git-log).
>
> Restore the correct messages.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2016-11-14 00:15:27

by Rafael J. Wysocki

Subject: Re: [PATCH v3] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus()

On Thursday, October 20, 2016 12:18:58 PM Stephen Boyd wrote:
> On 10/20, Masahiro Yamada wrote:
> > These log messages are wrong because _of_get_opp_desc_node() returns
> > an operating-points-v2 node.
> >
> > Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed
> > static checker warnings, and reworded the messages at the same time
> > (but the latter was not mentioned in the git-log).
> >
> > Restore the correct messages.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
>
> Reviewed-by: Stephen Boyd <[email protected]>

Applied.

Thanks,
Rafael