2016-10-25 16:25:19

by Thor Thayer

Subject: [PATCH] gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing

From: Thor Thayer <[email protected]>

Confirm the chip->parent is valid before dereferencing because
the parent parameter is optional.

Signed-off-by: Thor Thayer <[email protected]>
---
drivers/gpio/gpiolib-devprop.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/gpio/gpiolib-devprop.c b/drivers/gpio/gpiolib-devprop.c
index 17bfc41..27f383b 100644
--- a/drivers/gpio/gpiolib-devprop.c
+++ b/drivers/gpio/gpiolib-devprop.c
@@ -31,6 +31,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip)
const char **names;
int ret, i;

+ if (!chip->parent) {
+ dev_warn(&gdev->dev, "GPIO chip parent is NULL\n");
+ return;
+ }
+
ret = device_property_read_string_array(chip->parent, "gpio-line-names",
NULL, 0);
if (ret < 0)
--
1.9.1

2016-10-25 18:24:08

by Linus Walleij

Subject: Re: [PATCH] gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing

On Tue, Oct 25, 2016 at 6:31 PM, <[email protected]> wrote:

> From: Thor Thayer <[email protected]>
>
> Confirm the chip->parent is valid before dereferencing because
> the parent parameter is optional.
>
> Signed-off-by: Thor Thayer <[email protected]>

I wish it wasn't. Not much to do about though.

Patch applied.

Yours,
Linus Walleij