2016-11-11 18:01:04

by Deepa Dinamani

Subject: [RESEND PATCH] fs: jfs: Replace CURRENT_TIME_SEC by current_time()

jfs uses nanosecond granularity for filesystem timestamps.
Only this assignment is not using nanosecond granularity.
Use current_time() to get the right granularity.

Signed-off-by: Deepa Dinamani <[email protected]>
Acked-by: Dave Kleikamp <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
---
fs/jfs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
index 8653cac..b6fd1ff 100644
--- a/fs/jfs/ioctl.c
+++ b/fs/jfs/ioctl.c
@@ -121,7 +121,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)

jfs_set_inode_flags(inode);
inode_unlock(inode);
- inode->i_ctime = CURRENT_TIME_SEC;
+ inode->i_ctime = current_time(inode);
mark_inode_dirty(inode);
setflags_out:
mnt_drop_write_file(filp);
--
2.7.4

2016-11-11 18:42:28

by Dave Kleikamp

Subject: Re: [RESEND PATCH] fs: jfs: Replace CURRENT_TIME_SEC by current_time()

On 11/11/2016 12:00 PM, Deepa Dinamani wrote:
> jfs uses nanosecond granularity for filesystem timestamps.
> Only this assignment is not using nanosecond granularity.
> Use current_time() to get the right granularity.

I had thought these were being handled as a group. I'll push this one
through the jfs tree.

Thanks,
Shaggy

>
> Signed-off-by: Deepa Dinamani <[email protected]>
> Acked-by: Dave Kleikamp <[email protected]>
> Reviewed-by: Arnd Bergmann <[email protected]>
> ---
> fs/jfs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> index 8653cac..b6fd1ff 100644
> --- a/fs/jfs/ioctl.c
> +++ b/fs/jfs/ioctl.c
> @@ -121,7 +121,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>
> jfs_set_inode_flags(inode);
> inode_unlock(inode);
> - inode->i_ctime = CURRENT_TIME_SEC;
> + inode->i_ctime = current_time(inode);
> mark_inode_dirty(inode);
> setflags_out:
> mnt_drop_write_file(filp);
>

2016-11-11 18:50:32

by Deepa Dinamani

Subject: Re: [RESEND PATCH] fs: jfs: Replace CURRENT_TIME_SEC by current_time()

On Fri, Nov 11, 2016 at 10:42 AM, Dave Kleikamp
<[email protected]> wrote:
> On 11/11/2016 12:00 PM, Deepa Dinamani wrote:
>> jfs uses nanosecond granularity for filesystem timestamps.
>> Only this assignment is not using nanosecond granularity.
>> Use current_time() to get the right granularity.
>
> I had thought these were being handled as a group. I'll push this one
> through the jfs tree.

Yes, that was the original plan.
Then, Greg suggested pushing only the big patches as a group and
sending individual filesystem patches separately.
Big patches introducing current_time() have been merged in 4.9 rc1.

-Deepa