2016-12-03 02:05:33

by Ivan Khoronzhuk

Subject: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

There is desc_read() macros to read desc fields, so no need to
use __raw_readl();

Signed-off-by: Ivan Khoronzhuk <[email protected]>
---
Based on net-next/master

drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index c776e45..d96dca5 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
}
desc_dma = desc_phys(pool, desc);

- status = __raw_readl(&desc->hw_mode);
+ status = desc_read(desc, hw_mode);
outlen = status & 0x7ff;
if (status & CPDMA_DESC_OWNER) {
chan->stats.busy_dequeue++;
--
2.7.4

2016-12-05 18:47:20

by Grygorii Strashko

Subject: Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
> There is desc_read() macros to read desc fields, so no need to
> use __raw_readl();
>
> Signed-off-by: Ivan Khoronzhuk <[email protected]>


I'm going to update it all at once as part of [1].

[1] https://lkml.org/lkml/2016/12/1/781

> ---
> Based on net-next/master
>
> drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index c776e45..d96dca5 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
> }
> desc_dma = desc_phys(pool, desc);
>
> - status = __raw_readl(&desc->hw_mode);
> + status = desc_read(desc, hw_mode);
> outlen = status & 0x7ff;
> if (status & CPDMA_DESC_OWNER) {
> chan->stats.busy_dequeue++;
>

--
regards,
-grygorii

2016-12-05 19:48:04

by David Miller

Subject: Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

From: Grygorii Strashko <[email protected]>
Date: Mon, 5 Dec 2016 12:47:16 -0600

>
>
> On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
>> There is desc_read() macros to read desc fields, so no need to
>> use __raw_readl();
>>
>> Signed-off-by: Ivan Khoronzhuk <[email protected]>
>
>
> I'm going to update it all at once as part of [1].
>
> [1] https://lkml.org/lkml/2016/12/1/781

Ok.