2017-03-31 08:12:56

by Hugues Fruchet

Subject: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600

GPIO bits clearing on pins assigned to STMPE1600
had no effects due to missing "clear registers"
settings within stmpe1600_regs[].
STMPE1600 does not have dedicated "clear registers",
but single "set/clear registers", hence stmpe1600_regs[]
"clear registers" (STMPE_IDX_GPCR_XXX) must be set to
same value as "set registers" (STMPE_IDX_GPSR_XXX), ie
STMPE1600_REG_GPSR_XXX.

Signed-off-by: Hugues Fruchet <[email protected]>
---
drivers/mfd/stmpe.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index b0c7bcd..566caca 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block)
[STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB,
[STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB,
[STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB,
+ [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB,
+ [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB,
[STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB,
[STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB,
[STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB,
--
1.9.1

2017-03-31 09:19:17

by Patrice CHOTARD

Subject: Re: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600

Hi Hugues

On 03/31/2017 10:12 AM, Hugues Fruchet wrote:
> GPIO bits clearing on pins assigned to STMPE1600
> had no effects due to missing "clear registers"
> settings within stmpe1600_regs[].
> STMPE1600 does not have dedicated "clear registers",
> but single "set/clear registers", hence stmpe1600_regs[]
> "clear registers" (STMPE_IDX_GPCR_XXX) must be set to
> same value as "set registers" (STMPE_IDX_GPSR_XXX), ie
> STMPE1600_REG_GPSR_XXX.
>
> Signed-off-by: Hugues Fruchet <[email protected]>
> ---
> drivers/mfd/stmpe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index b0c7bcd..566caca 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block)
> [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB,
> [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB,
> [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB,
> + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB,
> + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB,
> [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB,
> [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB,
>

Reviewed-by: Patrice Chotard <[email protected]>

Thanks

2017-04-03 10:29:28

by Lee Jones

Subject: Re: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600

On Fri, 31 Mar 2017, Hugues Fruchet wrote:

> GPIO bits clearing on pins assigned to STMPE1600
> had no effects due to missing "clear registers"
> settings within stmpe1600_regs[].
> STMPE1600 does not have dedicated "clear registers",
> but single "set/clear registers", hence stmpe1600_regs[]
> "clear registers" (STMPE_IDX_GPCR_XXX) must be set to
> same value as "set registers" (STMPE_IDX_GPSR_XXX), ie
> STMPE1600_REG_GPSR_XXX.
>
> Signed-off-by: Hugues Fruchet <[email protected]>
> ---
> drivers/mfd/stmpe.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index b0c7bcd..566caca 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block)
> [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB,
> [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB,
> [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB,
> + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB,
> + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB,
> [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB,
> [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB,

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog