2017-04-10 09:03:28

by Martin Kepplinger

Subject: [PATCH] input: misc: yealink: define packet offset __be16 instead of u16

sparse says

warning: incorrect type in assignment (different base types)
expected unsigned short [unsigned] [usertype] offset
got restricted __be16 [usertype] <noident>

for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the
first place shouldn't hurt.

Signed-off-by: Martin Kepplinger <[email protected]>
---
drivers/input/misc/yealink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h
index 1e0f523..934c247 100644
--- a/drivers/input/misc/yealink.h
+++ b/drivers/input/misc/yealink.h
@@ -28,7 +28,7 @@
struct yld_ctl_packet {
u8 cmd; /* command code, see below */
u8 size; /* 1-11, size of used data bytes. */
- u16 offset; /* internal packet offset */
+ __be16 offset; /* internal packet offset */
u8 data[11];
s8 sum; /* negative sum of 15 preceding bytes */
} __attribute__ ((packed));
--
2.1.4

2017-04-10 15:00:59

by Martin Kepplinger

Subject: [PATCH v2] input: misc: yealink: define packet offset __be16 instead of u16

sparse says

warning: incorrect type in assignment (different base types)
expected unsigned short [unsigned] [usertype] offset
got restricted __be16 [usertype] <noident>

for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the
first place shouldn't hurt.

Signed-off-by: Martin Kepplinger <[email protected]>
Signed-off-by: [email protected]
---
revision history
----------------
v2: add privately received Signed-off-by


drivers/input/misc/yealink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h
index 1e0f523..934c247 100644
--- a/drivers/input/misc/yealink.h
+++ b/drivers/input/misc/yealink.h
@@ -28,7 +28,7 @@
struct yld_ctl_packet {
u8 cmd; /* command code, see below */
u8 size; /* 1-11, size of used data bytes. */
- u16 offset; /* internal packet offset */
+ __be16 offset; /* internal packet offset */
u8 data[11];
s8 sum; /* negative sum of 15 preceding bytes */
} __attribute__ ((packed));
--
2.1.4

2017-04-11 03:40:02

by Dmitry Torokhov

Subject: Re: [PATCH v2] input: misc: yealink: define packet offset __be16 instead of u16

On Mon, Apr 10, 2017 at 05:00:22PM +0200, Martin Kepplinger wrote:
> sparse says
>
> warning: incorrect type in assignment (different base types)
> expected unsigned short [unsigned] [usertype] offset
> got restricted __be16 [usertype] <noident>
>
> for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the
> first place shouldn't hurt.
>
> Signed-off-by: Martin Kepplinger <[email protected]>
> Signed-off-by: [email protected]

Applied, thank you.

> ---
> revision history
> ----------------
> v2: add privately received Signed-off-by
>
>
> drivers/input/misc/yealink.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h
> index 1e0f523..934c247 100644
> --- a/drivers/input/misc/yealink.h
> +++ b/drivers/input/misc/yealink.h
> @@ -28,7 +28,7 @@
> struct yld_ctl_packet {
> u8 cmd; /* command code, see below */
> u8 size; /* 1-11, size of used data bytes. */
> - u16 offset; /* internal packet offset */
> + __be16 offset; /* internal packet offset */
> u8 data[11];
> s8 sum; /* negative sum of 15 preceding bytes */
> } __attribute__ ((packed));
> --
> 2.1.4
>

--
Dmitry