2017-04-08 07:18:52

by Jeremy Linton

Subject: [PATCH] reset: hi6220: Set module license so that it can be loaded

The hi6220_reset driver can be built as a standalone module
yet it cannot be loaded because it depends on GPL exported symbols.

Lets set the module license so that the module loads, and things like
the on-board kirin drm starts working.

Signed-off-by: Jeremy Linton <[email protected]>
---
drivers/reset/hisilicon/hi6220_reset.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
index 35ce53e..d5e5229 100644
--- a/drivers/reset/hisilicon/hi6220_reset.c
+++ b/drivers/reset/hisilicon/hi6220_reset.c
@@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
}

postcore_initcall(hi6220_reset_init);
+
+MODULE_LICENSE("GPL v2");
--
2.10.2

2017-04-10 02:07:42

by Xinliang Liu

Subject: Re: [PATCH] reset: hi6220: Set module license so that it can be loaded

On 8 April 2017 at 15:18, Jeremy Linton <[email protected]> wrote:
> The hi6220_reset driver can be built as a standalone module
> yet it cannot be loaded because it depends on GPL exported symbols.
>
> Lets set the module license so that the module loads, and things like
> the on-board kirin drm starts working.
>
> Signed-off-by: Jeremy Linton <[email protected]>

reviewed-by: Xinliang Liu <[email protected]>

Thanks,
-xinliang

> ---
> drivers/reset/hisilicon/hi6220_reset.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 35ce53e..d5e5229 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
> }
>
> postcore_initcall(hi6220_reset_init);
> +
> +MODULE_LICENSE("GPL v2");
> --
> 2.10.2
>

2017-04-10 09:03:05

by Philipp Zabel

Subject: Re: [PATCH] reset: hi6220: Set module license so that it can be loaded

On Sat, 2017-04-08 at 02:18 -0500, Jeremy Linton wrote:
> The hi6220_reset driver can be built as a standalone module
> yet it cannot be loaded because it depends on GPL exported symbols.
>
> Lets set the module license so that the module loads, and things like
> the on-board kirin drm starts working.
>
> Signed-off-by: Jeremy Linton <[email protected]>
> ---
> drivers/reset/hisilicon/hi6220_reset.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 35ce53e..d5e5229 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
> }
>
> postcore_initcall(hi6220_reset_init);
> +
> +MODULE_LICENSE("GPL v2");

Applied, thanks.

regards
Philipp