2017-04-20 21:23:26

by Anatolij Gustschin

Subject: [PATCH] gpio: export add/remove lookup table functions

For hot-pluggable devices adding GPIOs dynamically we need to
assemble and add the gpio lookup tables at probe time in modules,
so that requesting these GPIOs in attached drivers can work.
Export lookup table functions for modules.

Signed-off-by: Anatolij Gustschin <[email protected]>
---
drivers/gpio/gpiolib.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 4aa1e78..9196b1e 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -3008,6 +3008,7 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)

mutex_unlock(&gpio_lookup_lock);
}
+EXPORT_SYMBOL_GPL(gpiod_add_lookup_table);

/**
* gpiod_remove_lookup_table() - unregister GPIO device consumers
@@ -3021,6 +3022,7 @@ void gpiod_remove_lookup_table(struct gpiod_lookup_table *table)

mutex_unlock(&gpio_lookup_lock);
}
+EXPORT_SYMBOL_GPL(gpiod_remove_lookup_table);

static struct gpiod_lookup_table *gpiod_find_lookup_table(struct device *dev)
{
--
2.7.4

2017-04-21 19:24:54

by Andy Shevchenko

Subject: Re: [PATCH] gpio: export add/remove lookup table functions

On Fri, Apr 21, 2017 at 12:23 AM, Anatolij Gustschin <[email protected]> wrote:
> For hot-pluggable devices adding GPIOs dynamically we need to
> assemble and add the gpio lookup tables at probe time in modules,
> so that requesting these GPIOs in attached drivers can work.
> Export lookup table functions for modules.
>
> Signed-off-by: Anatolij Gustschin <[email protected]>

...and still a question "Do we go with stubs for them in case of !GPIOLIB?"

Patch below looks good to me:
Reviewed-by: Andy Shevchenko <[email protected]>

> ---
> drivers/gpio/gpiolib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 4aa1e78..9196b1e 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -3008,6 +3008,7 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)
>
> mutex_unlock(&gpio_lookup_lock);
> }
> +EXPORT_SYMBOL_GPL(gpiod_add_lookup_table);
>
> /**
> * gpiod_remove_lookup_table() - unregister GPIO device consumers
> @@ -3021,6 +3022,7 @@ void gpiod_remove_lookup_table(struct gpiod_lookup_table *table)
>
> mutex_unlock(&gpio_lookup_lock);
> }
> +EXPORT_SYMBOL_GPL(gpiod_remove_lookup_table);
>
> static struct gpiod_lookup_table *gpiod_find_lookup_table(struct device *dev)
> {
> --
> 2.7.4
>



--
With Best Regards,
Andy Shevchenko

2017-04-24 14:04:37

by Anatolij Gustschin

Subject: [PATCH] gpiolib: Add stubs for gpiod lookup table interface

Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
for the !GPIOLIB case to prevent build errors. Also add prototypes.

Signed-off-by: Anatolij Gustschin <[email protected]>
---
include/linux/gpio/consumer.h | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index 933d936..6c0cc67 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -144,6 +144,11 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
enum gpiod_flags flags,
const char *label);

+struct gpiod_lookup_table;
+
+void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
+
#else /* CONFIG_GPIOLIB */

static inline int gpiod_count(struct device *dev, const char *con_id)
@@ -435,6 +440,16 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
return ERR_PTR(-ENOSYS);
}

+struct gpiod_lookup_table;
+
+static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table)
+{
+}
+
+static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table *table)
+{
+}
+
#endif /* CONFIG_GPIOLIB */

static inline
--
2.7.4

2017-04-24 14:08:13

by Anatolij Gustschin

Subject: Re: [PATCH] gpio: export add/remove lookup table functions

On Fri, 21 Apr 2017 22:24:49 +0300
Andy Shevchenko [email protected] wrote:
...
>...and still a question "Do we go with stubs for them in case of !GPIOLIB?"

I've just sent a patch.

>Patch below looks good to me:

Thanks for review!

Anatolij

2017-04-26 21:31:39

by Andy Shevchenko

Subject: Re: [PATCH] gpiolib: Add stubs for gpiod lookup table interface

On Mon, Apr 24, 2017 at 5:04 PM, Anatolij Gustschin <[email protected]> wrote:
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors. Also add prototypes.

One nit below, otherwise
FWIW:
Reviewed-by: Andy Shevchenko <[email protected]>

Linus, it would be nice if are okay with this approach. It will fix
that one user which might break a buiid on some kernel configurations.

>
> Signed-off-by: Anatolij Gustschin <[email protected]>
> ---
> include/linux/gpio/consumer.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index 933d936..6c0cc67 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -144,6 +144,11 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
> enum gpiod_flags flags,
> const char *label);

> +struct gpiod_lookup_table;

> #else /* CONFIG_GPIOLIB */

> +struct gpiod_lookup_table;

No need to duplicate this. Just move out of #ifdef.

--
With Best Regards,
Andy Shevchenko