On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Add MT2701 i2c device node.
>
> Signed-off-by: Jun Gao <[email protected]>
> ---
> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 84 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> index a483798..3f5a96c 100644
> --- a/arch/arm/boot/dts/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mt2701-evb.dts
> @@ -28,7 +28,49 @@
> status = "okay";
> };
>
> +&i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins_a>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins_a>;
> + status = "okay";
> +};
> +
> +&i2c2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pins_a>;
> + status = "okay";
> +};
> +
> &pio {
> + i2c0_pins_a: i2c0@0 {
> + pins1 {
> + pinmux = <MT2701_PIN_75_SDA0__FUNC_SDA0>,
> + <MT2701_PIN_76_SCL0__FUNC_SCL0>;
> + bias-disable;
> + };
> + };
> +
> + i2c1_pins_a: i2c1@0 {
> + pins1 {
> + pinmux = <MT2701_PIN_57_SDA1__FUNC_SDA1>,
> + <MT2701_PIN_58_SCL1__FUNC_SCL1>;
> + bias-disable;
> + };
> + };
> +
> + i2c2_pins_a: i2c2@0 {
> + pins1 {
> + pinmux = <MT2701_PIN_77_SDA2__FUNC_SDA2>,
> + <MT2701_PIN_78_SCL2__FUNC_SCL2>;
> + bias-disable;
> + };
> + };
> +
> spi_pins_a: spi0@0 {
> pins_spi {
> pinmux = <MT2701_PIN_53_SPI0_CSN__FUNC_SPI0_CS>,
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index 8037210..1b6157e 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -286,6 +286,48 @@
> status = "disabled";
> };
>
> + i2c0: i2c@11007000 {
> + compatible = "mediatek,mt2701-i2c",
> + "mediatek,mt6577-i2c";
> + reg = <0 0x11007000 0 0x70>,
> + <0 0x11000200 0 0x80>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> + clock-div = <16>;
> + clocks = <&pericfg CLK_PERI_I2C0>, <&pericfg CLK_PERI_AP_DMA>;
> + clock-names = "main", "dma";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@11008000 {
> + compatible = "mediatek,mt2701-i2c",
> + "mediatek,mt6577-i2c";
> + reg = <0 0x11008000 0 0x70>,
> + <0 0x11000280 0 0x80>;
> + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_LOW>;
> + clock-div = <16>;
> + clocks = <&pericfg CLK_PERI_I2C1>, <&pericfg CLK_PERI_AP_DMA>;
> + clock-names = "main", "dma";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@11009000 {
> + compatible = "mediatek,mt2701-i2c",
> + "mediatek,mt6577-i2c";
> + reg = <0 0x11009000 0 0x70>,
> + <0 0x11000300 0 0x80>;
> + interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_LOW>;
> + clock-div = <16>;
> + clocks = <&pericfg CLK_PERI_I2C2>, <&pericfg CLK_PERI_AP_DMA>;
> + clock-names = "main", "dma";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> spi0: spi@1100a000 {
> compatible = "mediatek,mt2701-spi";
> #address-cells = <1>;
Dear Matthias,
Could you take this patch together with
[PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
Thanks!
On 12/06/17 13:54, Jun Gao wrote:
> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>> From: Jun Gao <[email protected]>
>>
>> Add MT2701 i2c device node.
>>
>> Signed-off-by: Jun Gao <[email protected]>
>> ---
>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 84 insertions(+)
[...]
>
> Dear Matthias,
>
> Could you take this patch together with
> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>
> Thanks!
>
They are both included in the pull request I send [1] [2], or do I miss
something?
Regards,
Matthias
[1]
https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
[2]
https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>
> On 12/06/17 13:54, Jun Gao wrote:
> > On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >> From: Jun Gao <[email protected]>
> >>
> >> Add MT2701 i2c device node.
> >>
> >> Signed-off-by: Jun Gao <[email protected]>
> >> ---
> >> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 84 insertions(+)
> [...]
> >
> > Dear Matthias,
> >
> > Could you take this patch together with
> > [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >
> > Thanks!
> >
>
> They are both included in the pull request I send [1] [2], or do I miss
> something?
>
> Regards,
> Matthias
>
> [1]
> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> [2]
> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
Dear Matthias,
Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
"mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
"mediatek,mt6577-i2c": for Mediatek MT6577
"mediatek,mt6589-i2c": for Mediatek MT6589
"mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
"mediatek,mt8173-i2c": for Mediatek MT8173
Thanks!
On 13/06/17 12:24, Jun Gao wrote:
> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>>
>> On 12/06/17 13:54, Jun Gao wrote:
>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>>>> From: Jun Gao <[email protected]>
>>>>
>>>> Add MT2701 i2c device node.
>>>>
>>>> Signed-off-by: Jun Gao <[email protected]>
>>>> ---
>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>>>> 2 files changed, 84 insertions(+)
>> [...]
>>>
>>> Dear Matthias,
>>>
>>> Could you take this patch together with
>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>>>
>>> Thanks!
>>>
>>
>> They are both included in the pull request I send [1] [2], or do I miss
>> something?
>>
>> Regards,
>> Matthias
>>
>> [1]
>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
>> [2]
>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
>
> Dear Matthias,
>
> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
>
> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> "mediatek,mt6577-i2c": for Mediatek MT6577
> "mediatek,mt6589-i2c": for Mediatek MT6589
> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> "mediatek,mt8173-i2c": for Mediatek MT8173
>
>
> Thanks!
>
You mean I should fix-up the patch to fit to the new binding
description? Or do you mean it should be MTxxxx instead of mtxxxx?
Regards,
Matthias
On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
>
> On 13/06/17 12:24, Jun Gao wrote:
> > On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
> >>
> >> On 12/06/17 13:54, Jun Gao wrote:
> >>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >>>> From: Jun Gao <[email protected]>
> >>>>
> >>>> Add MT2701 i2c device node.
> >>>>
> >>>> Signed-off-by: Jun Gao <[email protected]>
> >>>> ---
> >>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>> 2 files changed, 84 insertions(+)
> >> [...]
> >>>
> >>> Dear Matthias,
> >>>
> >>> Could you take this patch together with
> >>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >>>
> >>> Thanks!
> >>>
> >>
> >> They are both included in the pull request I send [1] [2], or do I miss
> >> something?
> >>
> >> Regards,
> >> Matthias
> >>
> >> [1]
> >> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> >> [2]
> >> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
> >
> > Dear Matthias,
> >
> > Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
> >
> > "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> > "mediatek,mt6577-i2c": for Mediatek MT6577
> > "mediatek,mt6589-i2c": for Mediatek MT6589
> > "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> > "mediatek,mt8173-i2c": for Mediatek MT8173
> >
> >
> > Thanks!
> >
>
> You mean I should fix-up the patch to fit to the new binding
> description? Or do you mean it should be MTxxxx instead of mtxxxx?
>
> Regards,
> Matthias
Dear Matthias,
I mean fix-up the patch to fit to the new binding description. Is it OK?
Thanks!
On 13/06/17 15:23, Jun Gao wrote:
> On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
>>
>> On 13/06/17 12:24, Jun Gao wrote:
>>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>>>>
>>>> On 12/06/17 13:54, Jun Gao wrote:
>>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>>>>>> From: Jun Gao <[email protected]>
>>>>>>
>>>>>> Add MT2701 i2c device node.
>>>>>>
>>>>>> Signed-off-by: Jun Gao <[email protected]>
>>>>>> ---
>>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>> 2 files changed, 84 insertions(+)
>>>> [...]
>>>>>
>>>>> Dear Matthias,
>>>>>
>>>>> Could you take this patch together with
>>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>>>>>
>>>>> Thanks!
>>>>>
>>>>
>>>> They are both included in the pull request I send [1] [2], or do I miss
>>>> something?
>>>>
>>>> Regards,
>>>> Matthias
>>>>
>>>> [1]
>>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
>>>> [2]
>>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
>>>
>>> Dear Matthias,
>>>
>>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
>>>
>>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
>>> "mediatek,mt6577-i2c": for Mediatek MT6577
>>> "mediatek,mt6589-i2c": for Mediatek MT6589
>>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
>>> "mediatek,mt8173-i2c": for Mediatek MT8173
>>>
>>>
>>> Thanks!
>>>
>>
>> You mean I should fix-up the patch to fit to the new binding
>> description? Or do you mean it should be MTxxxx instead of mtxxxx?
>>
>> Regards,
>> Matthias
>
> Dear Matthias,
>
> I mean fix-up the patch to fit to the new binding description. Is it OK?
>
Then I can't see the difference between what you are asking for and what
is already pushed to the repository. Please send a patch, that will make
things clearer.
Regards,
Matthias
On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:
>
> On 13/06/17 15:23, Jun Gao wrote:
> > On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
> >>
> >> On 13/06/17 12:24, Jun Gao wrote:
> >>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
> >>>>
> >>>> On 12/06/17 13:54, Jun Gao wrote:
> >>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >>>>>> From: Jun Gao <[email protected]>
> >>>>>>
> >>>>>> Add MT2701 i2c device node.
> >>>>>>
> >>>>>> Signed-off-by: Jun Gao <[email protected]>
> >>>>>> ---
> >>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>> 2 files changed, 84 insertions(+)
> >>>> [...]
> >>>>>
> >>>>> Dear Matthias,
> >>>>>
> >>>>> Could you take this patch together with
> >>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >>>>>
> >>>>> Thanks!
> >>>>>
> >>>>
> >>>> They are both included in the pull request I send [1] [2], or do I miss
> >>>> something?
> >>>>
> >>>> Regards,
> >>>> Matthias
> >>>>
> >>>> [1]
> >>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> >>>> [2]
> >>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
> >>>
> >>> Dear Matthias,
> >>>
> >>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
> >>>
> >>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> >>> "mediatek,mt6577-i2c": for Mediatek MT6577
> >>> "mediatek,mt6589-i2c": for Mediatek MT6589
> >>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> >>> "mediatek,mt8173-i2c": for Mediatek MT8173
> >>>
> >>>
> >>> Thanks!
> >>>
> >>
> >> You mean I should fix-up the patch to fit to the new binding
> >> description? Or do you mean it should be MTxxxx instead of mtxxxx?
> >>
> >> Regards,
> >> Matthias
> >
> > Dear Matthias,
> >
> > I mean fix-up the patch to fit to the new binding description. Is it OK?
> >
>
> Then I can't see the difference between what you are asking for and what
> is already pushed to the repository. Please send a patch, that will make
> things clearer.
>
> Regards,
> Matthias
Dear Matthias,
like this:
diff:
Required properties:
- compatible: value should be either of the following.
- (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
- (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
- (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
- (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
- (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length
of memory
mapped region.
- interrupts: interrupt number to the cpu.
Thanks!
On 14/06/17 03:11, Jun Gao wrote:
> On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:
>>
>> On 13/06/17 15:23, Jun Gao wrote:
>>> On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
>>>>
>>>> On 13/06/17 12:24, Jun Gao wrote:
>>>>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>>>>>>
>>>>>> On 12/06/17 13:54, Jun Gao wrote:
>>>>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>>>>>>>> From: Jun Gao <[email protected]>
>>>>>>>>
>>>>>>>> Add MT2701 i2c device node.
>>>>>>>>
>>>>>>>> Signed-off-by: Jun Gao <[email protected]>
>>>>>>>> ---
>>>>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>>>> 2 files changed, 84 insertions(+)
>>>>>> [...]
>>>>>>>
>>>>>>> Dear Matthias,
>>>>>>>
>>>>>>> Could you take this patch together with
>>>>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>>>>>>>
>>>>>>> Thanks!
>>>>>>>
>>>>>>
>>>>>> They are both included in the pull request I send [1] [2], or do I miss
>>>>>> something?
>>>>>>
>>>>>> Regards,
>>>>>> Matthias
>>>>>>
>>>>>> [1]
>>>>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
>>>>>> [2]
>>>>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
>>>>>
>>>>> Dear Matthias,
>>>>>
>>>>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
>>>>>
>>>>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
>>>>> "mediatek,mt6577-i2c": for Mediatek MT6577
>>>>> "mediatek,mt6589-i2c": for Mediatek MT6589
>>>>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
>>>>> "mediatek,mt8173-i2c": for Mediatek MT8173
>>>>>
>>>>>
>>>>> Thanks!
>>>>>
>>>>
>>>> You mean I should fix-up the patch to fit to the new binding
>>>> description? Or do you mean it should be MTxxxx instead of mtxxxx?
>>>>
>>>> Regards,
>>>> Matthias
>>>
>>> Dear Matthias,
>>>
>>> I mean fix-up the patch to fit to the new binding description. Is it OK?
>>>
>>
>> Then I can't see the difference between what you are asking for and what
>> is already pushed to the repository. Please send a patch, that will make
>> things clearer.
>>
>> Regards,
>> Matthias
>
> Dear Matthias,
>
> like this:
>
> diff:
> Required properties:
> - compatible: value should be either of the following.
> - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
> MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
> MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length
> of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
>
Please look at [2], this is already staged.
[2]
https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
On Wed, 2017-06-14 at 11:24 +0200, Matthias Brugger wrote:
>
> On 14/06/17 03:11, Jun Gao wrote:
> > On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:
> >>
> >> On 13/06/17 15:23, Jun Gao wrote:
> >>> On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
> >>>>
> >>>> On 13/06/17 12:24, Jun Gao wrote:
> >>>>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
> >>>>>>
> >>>>>> On 12/06/17 13:54, Jun Gao wrote:
> >>>>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >>>>>>>> From: Jun Gao <[email protected]>
> >>>>>>>>
> >>>>>>>> Add MT2701 i2c device node.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Jun Gao <[email protected]>
> >>>>>>>> ---
> >>>>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>>>> 2 files changed, 84 insertions(+)
> >>>>>> [...]
> >>>>>>>
> >>>>>>> Dear Matthias,
> >>>>>>>
> >>>>>>> Could you take this patch together with
> >>>>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >>>>>>>
> >>>>>>> Thanks!
> >>>>>>>
> >>>>>>
> >>>>>> They are both included in the pull request I send [1] [2], or do I miss
> >>>>>> something?
> >>>>>>
> >>>>>> Regards,
> >>>>>> Matthias
> >>>>>>
> >>>>>> [1]
> >>>>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> >>>>>> [2]
> >>>>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
> >>>>>
> >>>>> Dear Matthias,
> >>>>>
> >>>>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
> >>>>>
> >>>>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> >>>>> "mediatek,mt6577-i2c": for Mediatek MT6577
> >>>>> "mediatek,mt6589-i2c": for Mediatek MT6589
> >>>>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> >>>>> "mediatek,mt8173-i2c": for Mediatek MT8173
> >>>>>
> >>>>>
> >>>>> Thanks!
> >>>>>
> >>>>
> >>>> You mean I should fix-up the patch to fit to the new binding
> >>>> description? Or do you mean it should be MTxxxx instead of mtxxxx?
> >>>>
> >>>> Regards,
> >>>> Matthias
> >>>
> >>> Dear Matthias,
> >>>
> >>> I mean fix-up the patch to fit to the new binding description. Is it OK?
> >>>
> >>
> >> Then I can't see the difference between what you are asking for and what
> >> is already pushed to the repository. Please send a patch, that will make
> >> things clearer.
> >>
> >> Regards,
> >> Matthias
> >
> > Dear Matthias,
> >
> > like this:
> >
> > diff:
> > Required properties:
> > - compatible: value should be either of the following.
> > - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> > - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> > - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> > - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> > - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
> > MT2701
> > + "mediatek,mt6577-i2c": for Mediatek MT6577
> > + "mediatek,mt6589-i2c": for Mediatek MT6589
> > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
> > MT7623
> > + "mediatek,mt8173-i2c": for Mediatek MT8173
> > - reg: physical base address of the controller and dma base, length
> > of memory
> > mapped region.
> > - interrupts: interrupt number to the cpu.
> >
>
> Please look at [2], this is already staged.
>
> [2]
> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
Dear Matthias,
base on [2]
diff:
"mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577 i2c.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589 i2c.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with
mt7623 i2c.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173 i2c.
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
Thanks!