2017-06-22 12:05:00

by Arvind Yadav

Subject: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens

File size before:
text data bss dec hex filename
43100 2161 64 45325 b10d drivers/block/rbd.o

File size After adding 'const':
text data bss dec hex filename
43292 1969 64 45325 b10d drivers/block/rbd.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/block/rbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 454bf9c..2fb1912 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -802,7 +802,7 @@ enum {
Opt_err
};

-static match_table_t rbd_opts_tokens = {
+static const match_table_t rbd_opts_tokens = {
{Opt_queue_depth, "queue_depth=%d"},
/* int args above */
/* string args above */
@@ -4670,7 +4670,7 @@ static ssize_t rbd_image_refresh(struct device *dev,
NULL
};

-static struct attribute_group rbd_attr_group = {
+static const struct attribute_group rbd_attr_group = {
.attrs = rbd_attrs,
};

--
1.9.1

2017-06-22 12:23:05

by Joe Perches

Subject: Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens

On Thu, 2017-06-22 at 17:34 +0530, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 43100 2161 64 45325 b10d drivers/block/rbd.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 43292 1969 64 45325 b10d drivers/block/rbd.o

If you are going to do these conversions, I still think
it'd be better to use a standard struct declaration.

>From 2011, (const was also added)
http://lkml.iu.edu/hypermail/linux/kernel/1104.2/00738.html