2017-07-03 05:55:12

by Ryder Lee

Subject: [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags

The PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags are not needed,
since we should automatically assign resources if the firmware hasn't done it.

Signed-off-by: Ryder Lee <[email protected]>
---
drivers/pci/host/pcie-mediatek.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
index 51c6118..5a9d858 100644
--- a/drivers/pci/host/pcie-mediatek.c
+++ b/drivers/pci/host/pcie-mediatek.c
@@ -478,7 +478,6 @@ static int mtk_pcie_register_host(struct pci_host_bridge *host)
struct pci_bus *child;
int err;

- pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
host->busnr = pcie->busn.start;
host->dev.parent = pcie->dev;
host->ops = &mtk_pcie_ops;
--
1.9.1

2017-07-03 13:07:42

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags

On Mon, Jul 03, 2017 at 01:55:00PM +0800, Ryder Lee wrote:
> The PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags are not needed,
> since we should automatically assign resources if the firmware hasn't done it.
>
> Signed-off-by: Ryder Lee <[email protected]>

Folded into pci/host-mediatek, thanks!

> ---
> drivers/pci/host/pcie-mediatek.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
> index 51c6118..5a9d858 100644
> --- a/drivers/pci/host/pcie-mediatek.c
> +++ b/drivers/pci/host/pcie-mediatek.c
> @@ -478,7 +478,6 @@ static int mtk_pcie_register_host(struct pci_host_bridge *host)
> struct pci_bus *child;
> int err;
>
> - pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
> host->busnr = pcie->busn.start;
> host->dev.parent = pcie->dev;
> host->ops = &mtk_pcie_ops;
> --
> 1.9.1
>