2017-08-01 18:05:59

by Cihangir Akturk

Subject: [PATCH] staging: vboxvideo: select DRM_TTM

vboxvideo code uses various ttm_* functions, so it needs
"drivers/gpu/drm/ttm/*" to be built. In order to build these objects
select DRM_TTM.

This commit fixes "ttm_*" undefined build errors.

Signed-off-by: Cihangir Akturk <[email protected]>
---
drivers/staging/vboxvideo/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index f89f931..1f4182e 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
tristate "Virtual Box Graphics Card"
depends on DRM && X86 && PCI
select DRM_KMS_HELPER
+ select DRM_TTM
select GENERIC_ALLOCATOR
help
This is a KMS driver for the virtual Graphics Card used in
--
2.7.4

2017-08-03 10:40:24

by Hans de Goede

Subject: Re: [PATCH] staging: vboxvideo: select DRM_TTM

Hi,

On 01-08-17 20:05, Cihangir Akturk wrote:
> vboxvideo code uses various ttm_* functions, so it needs
> "drivers/gpu/drm/ttm/*" to be built. In order to build these objects
> select DRM_TTM.
>
> This commit fixes "ttm_*" undefined build errors.
>
> Signed-off-by: Cihangir Akturk <[email protected]>

Thank you for doing this, I had this on my todo list but I was
travelling:

Acked-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
> drivers/staging/vboxvideo/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
> index f89f931..1f4182e 100644
> --- a/drivers/staging/vboxvideo/Kconfig
> +++ b/drivers/staging/vboxvideo/Kconfig
> @@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
> tristate "Virtual Box Graphics Card"
> depends on DRM && X86 && PCI
> select DRM_KMS_HELPER
> + select DRM_TTM
> select GENERIC_ALLOCATOR
> help
> This is a KMS driver for the virtual Graphics Card used in
>