2017-08-02 04:20:17

by David Wittman

[permalink] [raw]
Subject: [PATCH] staging: lustre: declare fiemap_for_stripe static

Declare fiemap_for_stripe as static to fix sparse warnings:

> warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> static?

Signed-off-by: David Wittman <[email protected]>
---
drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index 8fc0bcc..334ecb1 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -1141,11 +1141,11 @@ struct fiemap_state {
bool fs_enough;
};

-int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
- struct lov_stripe_md *lsm,
- struct fiemap *fiemap, size_t *buflen,
- struct ll_fiemap_info_key *fmkey, int stripeno,
- struct fiemap_state *fs)
+static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
+ struct lov_stripe_md *lsm,
+ struct fiemap *fiemap, size_t *buflen,
+ struct ll_fiemap_info_key *fmkey, int stripeno,
+ struct fiemap_state *fs)
{
struct cl_object *subobj;
struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
--
2.7.4


2017-08-03 17:27:36

by James Simmons

[permalink] [raw]
Subject: Re: [PATCH] staging: lustre: declare fiemap_for_stripe static


> Declare fiemap_for_stripe as static to fix sparse warnings:
>
> > warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> > static?

Acked-by: James Simmons <[email protected]>

> Signed-off-by: David Wittman <[email protected]>
> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index 8fc0bcc..334ecb1 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -1141,11 +1141,11 @@ struct fiemap_state {
> bool fs_enough;
> };
>
> -int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> - struct lov_stripe_md *lsm,
> - struct fiemap *fiemap, size_t *buflen,
> - struct ll_fiemap_info_key *fmkey, int stripeno,
> - struct fiemap_state *fs)
> +static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> + struct lov_stripe_md *lsm,
> + struct fiemap *fiemap, size_t *buflen,
> + struct ll_fiemap_info_key *fmkey, int stripeno,
> + struct fiemap_state *fs)
> {
> struct cl_object *subobj;
> struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>