This patch series based on v4.13-rc1, include MT7622 i2c dt-binding
and compatible.
Jun Gao (2):
dt-bindings: i2c: Add MediaTek MT7622 i2c binding
i2c: mediatek: Add i2c compatible for MediaTek MT7622
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
2 files changed, 24 insertions(+), 5 deletions(-)
--
1.8.1.1
From: Jun Gao <[email protected]>
Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
controller, MT7622 limit message size to 255, and not support
4GB DMA mode.
Signed-off-by: Jun Gao <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..ff9ac61 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7622-i2c": for Mediatek MT7622
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
From: Jun Gao <[email protected]>
Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limit message size to 255, and not support 4GB DMA mode.
Signed-off-by: Jun Gao <[email protected]>
---
drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..2c7f847 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,14 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+ .max_write_len = 65535,
+ .max_read_len = 65535,
+ .max_comb_1st_msg_len = 65535,
+ .max_comb_2nd_msg_len = 65535,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +198,15 @@ struct mtk_i2c {
.support_33bits = 0,
};
+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +218,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1
On Wed, 2017-08-09 at 15:43 +0800, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limit message size to 255, and not support 4GB DMA mode.
Jun,
Do you mean message numbers?
Joe.C
>
> Signed-off-by: Jun Gao <[email protected]>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 9bedf0b..2c7f847 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -172,6 +172,14 @@ struct mtk_i2c {
> .max_comb_2nd_msg_len = 31,
> };
>
> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> + .max_num_msgs = 255,
> + .max_write_len = 65535,
> + .max_read_len = 65535,
> + .max_comb_1st_msg_len = 65535,
> + .max_comb_2nd_msg_len = 65535,
> +};
> +
> static const struct mtk_i2c_compatible mt6577_compat = {
> .quirks = &mt6577_i2c_quirks,
> .pmic_i2c = 0,
> @@ -190,6 +198,15 @@ struct mtk_i2c {
> .support_33bits = 0,
> };
>
> +static const struct mtk_i2c_compatible mt7622_compat = {
> + .quirks = &mt7622_i2c_quirks,
> + .pmic_i2c = 0,
> + .dcm = 1,
> + .auto_restart = 1,
> + .aux_len_reg = 1,
> + .support_33bits = 0,
> +};
> +
> static const struct mtk_i2c_compatible mt8173_compat = {
> .pmic_i2c = 0,
> .dcm = 1,
> @@ -201,6 +218,7 @@ struct mtk_i2c {
> static const struct of_device_id mtk_i2c_of_match[] = {
> { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> {}
> };
On Wed, 2017-08-09 at 17:40 +0800, Yingjoe Chen wrote:
> On Wed, 2017-08-09 at 15:43 +0800, Jun Gao wrote:
> > From: Jun Gao <[email protected]>
> >
> > Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> > MT7622 limit message size to 255, and not support 4GB DMA mode.
>
>
> Jun,
>
> Do you mean message numbers?
>
>
> Joe.C
>
Yes, bit7~bit0 of i2c register TRANSAC_LEN will be used as message
numbers.
Jun
> >
> > Signed-off-by: Jun Gao <[email protected]>
> > ---
> > drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> > index 9bedf0b..2c7f847 100644
> > --- a/drivers/i2c/busses/i2c-mt65xx.c
> > +++ b/drivers/i2c/busses/i2c-mt65xx.c
> > @@ -172,6 +172,14 @@ struct mtk_i2c {
> > .max_comb_2nd_msg_len = 31,
> > };
> >
> > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > + .max_num_msgs = 255,
> > + .max_write_len = 65535,
> > + .max_read_len = 65535,
> > + .max_comb_1st_msg_len = 65535,
> > + .max_comb_2nd_msg_len = 65535,
> > +};
> > +
> > static const struct mtk_i2c_compatible mt6577_compat = {
> > .quirks = &mt6577_i2c_quirks,
> > .pmic_i2c = 0,
> > @@ -190,6 +198,15 @@ struct mtk_i2c {
> > .support_33bits = 0,
> > };
> >
> > +static const struct mtk_i2c_compatible mt7622_compat = {
> > + .quirks = &mt7622_i2c_quirks,
> > + .pmic_i2c = 0,
> > + .dcm = 1,
> > + .auto_restart = 1,
> > + .aux_len_reg = 1,
> > + .support_33bits = 0,
> > +};
> > +
> > static const struct mtk_i2c_compatible mt8173_compat = {
> > .pmic_i2c = 0,
> > .dcm = 1,
> > @@ -201,6 +218,7 @@ struct mtk_i2c {
> > static const struct of_device_id mtk_i2c_of_match[] = {
> > { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> > { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> > + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> > { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> > {}
> > };
>
>
On 08/09/2017 09:43 AM, Jun Gao wrote:
> From: Jun Gao <[email protected]>
>
> Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
> controller, MT7622 limit message size to 255, and not support
> 4GB DMA mode.
>
> Signed-off-by: Jun Gao <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> index bd5a7be..ff9ac61 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>
> Required properties:
> - compatible: value should be either of the following.
> - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7622-i2c": for Mediatek MT7622
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
>
In the next series, could you please make sure not to change the indentation.
Thanks a lot,
Matthias
On Mon, 2017-08-14 at 11:36 +0200, Matthias Brugger wrote:
>
> On 08/09/2017 09:43 AM, Jun Gao wrote:
> > From: Jun Gao <[email protected]>
> >
> > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
> > controller, MT7622 limit message size to 255, and not support
> > 4GB DMA mode.
> >
> > Signed-off-by: Jun Gao <[email protected]>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > index bd5a7be..ff9ac61 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
> >
> > Required properties:
> > - compatible: value should be either of the following.
> > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> > - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> > - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> > - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> > + "mediatek,mt6577-i2c": for Mediatek MT6577
> > + "mediatek,mt6589-i2c": for Mediatek MT6589
> > + "mediatek,mt7622-i2c": for Mediatek MT7622
> > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> > + "mediatek,mt8173-i2c": for Mediatek MT8173
> > - reg: physical base address of the controller and dma base, length of memory
> > mapped region.
> > - interrupts: interrupt number to the cpu.
> >
>
> In the next series, could you please make sure not to change the indentation.
>
> Thanks a lot,
> Matthias
Please review [PATCH v2 1/2], I will not change the indentation any
more. Thanks!
Jun