2017-08-28 18:08:35

by Bhumika Goyal

Subject: [PATCH] IPMI: make ipmi_poweroff_handler const

Make this const as it is only passed to a const argument of the function
ipmi_create_user.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/char/ipmi/ipmi_poweroff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
index 9f2e3be..cd0f41f 100644
--- a/drivers/char/ipmi/ipmi_poweroff.c
+++ b/drivers/char/ipmi/ipmi_poweroff.c
@@ -133,7 +133,7 @@ static void receive_handler(struct ipmi_recv_msg *recv_msg, void *handler_data)
complete(comp);
}

-static struct ipmi_user_hndl ipmi_poweroff_handler = {
+static const struct ipmi_user_hndl ipmi_poweroff_handler = {
.ipmi_recv_hndl = receive_handler
};

--
1.9.1

2017-08-28 18:40:07

by Corey Minyard

Subject: Re: [PATCH] IPMI: make ipmi_poweroff_handler const

On 08/28/2017 01:08 PM, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> ipmi_create_user.

Queued for the next kernel release.

-corey

> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> drivers/char/ipmi/ipmi_poweroff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
> index 9f2e3be..cd0f41f 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -133,7 +133,7 @@ static void receive_handler(struct ipmi_recv_msg *recv_msg, void *handler_data)
> complete(comp);
> }
>
> -static struct ipmi_user_hndl ipmi_poweroff_handler = {
> +static const struct ipmi_user_hndl ipmi_poweroff_handler = {
> .ipmi_recv_hndl = receive_handler
> };
>