2017-09-20 09:41:59

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH v2 1/2] [media] coda: Handle return value of kasprintf

kasprintf() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v2 :
Calling coda_free_framebuffers to release already allocated buffers.

drivers/media/platform/coda/coda-bit.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c
index 291c409..bfc4ecf 100644
--- a/drivers/media/platform/coda/coda-bit.c
+++ b/drivers/media/platform/coda/coda-bit.c
@@ -417,6 +417,10 @@ static int coda_alloc_framebuffers(struct coda_ctx *ctx,
dev->devtype->product != CODA_DX6)
size += ysize / 4;
name = kasprintf(GFP_KERNEL, "fb%d", i);
+ if (!name) {
+ coda_free_framebuffers(ctx);
+ return -ENOMEM;
+ }
ret = coda_alloc_context_buf(ctx, &ctx->internal_frames[i],
size, name);
kfree(name);
--
1.9.1


2017-09-20 10:05:06

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] [media] coda: Handle return value of kasprintf

On Wed, 2017-09-20 at 15:10 +0530, Arvind Yadav wrote:
> kasprintf() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <[email protected]>
---
> changes in v2 :
> Calling coda_free_framebuffers to release already allocated buffers.

Thanks,

Reviewed-by: Philipp Zabel <[email protected]>

regards
Philipp