2017-09-20 15:14:11

by Meng Xu

Subject: [PATCH] mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo

Since right after the user copy, we are going to
memset(&karg, 0, sizeof(karg)), the copy_from_user is redundant

Signed-off-by: Meng Xu <[email protected]>
---
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
index bdffb69..d448fed 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
@@ -1065,12 +1065,6 @@ _ctl_getiocinfo(struct MPT3SAS_ADAPTER *ioc, void __user *arg)
{
struct mpt3_ioctl_iocinfo karg;

- if (copy_from_user(&karg, arg, sizeof(karg))) {
- pr_err("failure at %s:%d/%s()!\n",
- __FILE__, __LINE__, __func__);
- return -EFAULT;
- }
-
dctlprintk(ioc, pr_info(MPT3SAS_FMT "%s: enter\n", ioc->name,
__func__));

--
2.7.4

2017-09-20 15:19:52

by Christoph Hellwig

Subject: Re: [PATCH] mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2017-09-25 23:23:19

by Martin K. Petersen

Subject: Re: [PATCH] mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo

Meng,

> Since right after the user copy, we are going to
> memset(&karg, 0, sizeof(karg)), the copy_from_user is redundant

Applied to 4.15/scsi-queue. Thank you!

--
Martin K. Petersen Oracle Linux Engineering