2018-02-02 15:53:35

by Jack Stocker

Subject: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

From: Jack Stocker <[email protected]>

Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
start correctly at boot.

Device ids found here:
usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard

Signed-off-by: Jack Stocker <[email protected]>
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..9eb92dc 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },

+ /* Corsair K70 RGB */
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
/* MIDI keyboard WORLDE MINI */
{ USB_DEVICE(0x1c75, 0x0204), .driver_info =
USB_QUIRK_CONFIG_INTF_STRINGS },
--
2.7.4

2018-02-02 18:22:21

by Dmitry Fleytman

Subject: Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

> On 2 Feb 2018, at 17:51, JackStocker <[email protected]> wrote:
>
> From: Jack Stocker <[email protected]>
>
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
>
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard

Reviewed-by: Dmitry Fleytman <[email protected]>

>
> Signed-off-by: Jack Stocker <[email protected]>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..9eb92dc 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Corsair Strafe RGB */
> { USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
>
> + /* Corsair K70 RGB */
> + { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +
> /* MIDI keyboard WORLDE MINI */
> { USB_DEVICE(0x1c75, 0x0204), .driver_info =
> USB_QUIRK_CONFIG_INTF_STRINGS },
> --
> 2.7.4
>

2018-02-04 13:37:47

by Kai-Heng Feng

Subject: Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

> On 2 Feb 2018, at 11:51 PM, JackStocker <[email protected]> wrote:
>
> From: Jack Stocker <[email protected]>
>
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
>
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
>
> Signed-off-by: Jack Stocker <[email protected]>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..9eb92dc 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Corsair Strafe RGB */
> { USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
>
> + /* Corsair K70 RGB */
> + { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +

I think this change should move up, to make the table follows an ascending order.

> /* MIDI keyboard WORLDE MINI */
> { USB_DEVICE(0x1c75, 0x0204), .driver_info =
> USB_QUIRK_CONFIG_INTF_STRINGS },
> --
> 2.7.4
>

2018-02-04 16:29:32

by Jack Stocker

Subject: [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards

Do you mean like this?

Signed-off-by: JackStocker <[email protected]>
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..0405d68 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },

+ /* Corsair K70 RGB */
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },

--
2.7.4

2018-02-04 16:41:27

by Kai-Heng Feng

Subject: Re: [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards

> On 5 Feb 2018, at 12:18 AM, JackStocker <[email protected]> wrote:
>
> Do you mean like this?

Yes, with proper commit message.

>
> Signed-off-by: JackStocker <[email protected]>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..0405d68 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> { USB_DEVICE(0x1a0a, 0x0200), .driver_info =
> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>
> + /* Corsair K70 RGB */
> + { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +
> /* Corsair Strafe RGB */
> { USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
>
> --
> 2.7.4
>

2018-02-04 16:52:27

by Jack Stocker

Subject: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
start correctly at boot.

Device ids found here:
usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard

Signed-off-by: JackStocker <[email protected]>
---
Changes in v3:
- Added correct v1 commit message.
Changes in v2:
- Moved K70 entry above Strafe to preserve ascending order.

drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..0405d68 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },

+ /* Corsair K70 RGB */
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },

--
2.7.4

2018-02-15 18:04:35

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

On Thu, Feb 15, 2018 at 05:59:34PM +0000, Jack wrote:
> On 15/02/18 17:35, Greg Kroah-Hartman wrote:
> > On Sun, Feb 04, 2018 at 04:50:58PM +0000, JackStocker wrote:
> > > Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> > > Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> > > start correctly at boot.
> > >
> > > Device ids found here:
> > > usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> > > usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> > > usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
> > >
> > > Signed-off-by: JackStocker <[email protected]>
> > I need a "real" name here please.
> >
> > thanks,
> >
> > greg k-h
> As in 'Jack Stocker' is that correct?

If that is how you sign legal documents, yes :)

thanks,

greg k-h

2018-02-15 18:26:42

by Jack Stocker

Subject: [PATCH v4] Add delay-init quirk for Corsair K70 RGB keyboards

Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
start correctly at boot.

Device ids found here:
usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard

Signed-off-by: Jack Stocker <[email protected]>
---
Changes in v4:
- Corrected 'real' name.
Changes in v3:
- Added correct v1 commit message.
Changes in v2:
- Moved K70 entry above Strafe to preserve ascending order.

drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a6aaf2f..0405d68 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -218,6 +218,9 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },

+ /* Corsair K70 RGB */
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },

--
2.7.4

2018-02-16 10:47:10

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

On Sun, Feb 04, 2018 at 04:50:58PM +0000, JackStocker wrote:
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
>
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
>
> Signed-off-by: JackStocker <[email protected]>

I need a "real" name here please.

thanks,

greg k-h

2018-02-16 11:51:44

by Jack Stocker

Subject: Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

On 15/02/18 17:35, Greg Kroah-Hartman wrote:
> On Sun, Feb 04, 2018 at 04:50:58PM +0000, JackStocker wrote:
>> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
>> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
>> start correctly at boot.
>>
>> Device ids found here:
>> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
>> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
>>
>> Signed-off-by: JackStocker <[email protected]>
> I need a "real" name here please.
>
> thanks,
>
> greg k-h
As in 'Jack Stocker' is that correct?

Cheers,
Jack