From: Patrice Chotard <[email protected]>
This series fixes all dtc warnings related to STi platforms dt files.
It has been reported by Rob Herring [1]
For most of implicated node, the addition of a fake reg property
fixes these warnings.
[1] https://www.spinics.net/lists/devicetree/msg206209.html
v2: _ add a fake reg property to node without reg property, instead
of moving them outside soc node.
Patrice Chotard (7):
ARM: dts: STi: fix bindings notation
ARM: dts: STi: Add gpio polarity for "hdmi,hpd-gpio" property
ARM: dts: STi: Move clocks without reg outside soc
ARM: dts: STi: Move leds node outside soc node
ARM: dts: STi: Add fake reg property for sti-display-subsystem
ARM: dts: STi: Add fake reg property for miphy28lp_phy
ARM: dts: STi: Add fake reg property for irq-syscfg
ARM: dts: STi: Add fake reg property for remote processors
ARM: dts: STi: Add fake reg for restart, powerdown and
picophy/softreset
ARM: dts: STi: Add fake reg property for usb2_picophyX nodes
ARM: dts: STi: Add fake reg property for sound related nodes
ARM: dts: STi: Add fake reg property for clocks
ARM: dts: STi: Move clk_sysin clock ouside soc node
ARM: dts: STi: Remove unused clk_ext2f_a9 clock
arch/arm/boot/dts/stih407-b2120.dts | 2 +-
arch/arm/boot/dts/stih407-clock.dtsi | 40 +++++++++-------------
arch/arm/boot/dts/stih407-family.dtsi | 31 +++++++++++------
arch/arm/boot/dts/stih407-pinctrl.dtsi | 10 +++---
arch/arm/boot/dts/stih407.dtsi | 4 +--
arch/arm/boot/dts/stih410-b2120.dts | 8 ++---
arch/arm/boot/dts/stih410-b2260.dts | 62 +++++++++++++++++-----------------
arch/arm/boot/dts/stih410-clock.dtsi | 42 ++++++++++-------------
arch/arm/boot/dts/stih410-pinctrl.dtsi | 2 +-
arch/arm/boot/dts/stih410.dtsi | 13 ++++---
arch/arm/boot/dts/stih418-b2199.dts | 30 ++++++++--------
arch/arm/boot/dts/stih418-clock.dtsi | 42 ++++++++++-------------
arch/arm/boot/dts/stih418.dtsi | 6 ++--
arch/arm/boot/dts/stihxxx-b2120.dtsi | 41 +++++++++++-----------
14 files changed, 163 insertions(+), 170 deletions(-)
--
1.9.1
From: Patrice Chotard <[email protected]>
As clk_sysin node describes the external oscillator, there is no
reason to put it into soc node.
This allows to fix the following warnings when compiling
dtb with W=1 option :
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /clocks/clk-sysin missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /clocks/clk-sysin missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /clocks/clk-sysin missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ move clk_sys_in outside soc node
arch/arm/boot/dts/stih407-clock.dtsi | 18 +++++++++---------
arch/arm/boot/dts/stih410-clock.dtsi | 20 ++++++++++----------
arch/arm/boot/dts/stih418-clock.dtsi | 20 ++++++++++----------
3 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
index 1bba47e06ebe..f4e21e2234c9 100644
--- a/arch/arm/boot/dts/stih407-clock.dtsi
+++ b/arch/arm/boot/dts/stih407-clock.dtsi
@@ -7,21 +7,21 @@
*/
#include <dt-bindings/clock/stih407-clks.h>
/ {
+ /*
+ * Fixed 30MHz oscillator inputs to SoC
+ */
+ clk_sysin: clk-sysin {
+ #clock-cells = <0>;
+ compatible = "fixed-clock";
+ clock-frequency = <30000000>;
+ };
+
clocks {
#address-cells = <1>;
#size-cells = <1>;
ranges;
/*
- * Fixed 30MHz oscillator inputs to SoC
- */
- clk_sysin: clk-sysin {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <30000000>;
- };
-
- /*
* ARM Peripheral clock for timers
*/
arm_periph_clk: clk-m-a9-periphs@0 {
diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index 41fb1a910d49..9481f8769e8a 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -7,6 +7,16 @@
*/
#include <dt-bindings/clock/stih410-clks.h>
/ {
+ /*
+ * Fixed 30MHz oscillator inputs to SoC
+ */
+ clk_sysin: clk-sysin {
+ #clock-cells = <0>;
+ compatible = "fixed-clock";
+ clock-frequency = <30000000>;
+ clock-output-names = "CLK_SYSIN";
+ };
+
clocks {
#address-cells = <1>;
#size-cells = <1>;
@@ -15,16 +25,6 @@
compatible = "st,stih410-clk", "simple-bus";
/*
- * Fixed 30MHz oscillator inputs to SoC
- */
- clk_sysin: clk-sysin {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <30000000>;
- clock-output-names = "CLK_SYSIN";
- };
-
- /*
* ARM Peripheral clock for timers
*/
arm_periph_clk: clk-m-a9-periphs@0 {
diff --git a/arch/arm/boot/dts/stih418-clock.dtsi b/arch/arm/boot/dts/stih418-clock.dtsi
index 50413eabe73a..9e3790198f51 100644
--- a/arch/arm/boot/dts/stih418-clock.dtsi
+++ b/arch/arm/boot/dts/stih418-clock.dtsi
@@ -7,6 +7,16 @@
*/
#include <dt-bindings/clock/stih418-clks.h>
/ {
+ /*
+ * Fixed 30MHz oscillator inputs to SoC
+ */
+ clk_sysin: clk-sysin {
+ #clock-cells = <0>;
+ compatible = "fixed-clock";
+ clock-frequency = <30000000>;
+ clock-output-names = "CLK_SYSIN";
+ };
+
clocks {
#address-cells = <1>;
#size-cells = <1>;
@@ -15,16 +25,6 @@
compatible = "st,stih418-clk", "simple-bus";
/*
- * Fixed 30MHz oscillator inputs to SoC
- */
- clk_sysin: clk-sysin {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <30000000>;
- clock-output-names = "CLK_SYSIN";
- };
-
- /*
* ARM Peripheral clock for timers
*/
arm_periph_clk: clk-m-a9-periphs@0 {
--
1.9.1
From: Patrice Chotard <[email protected]>
Add fake reg property for restart, powerdown, picophyreset
and softreset.
This allows to fix the following warning when compiling
dtb with W=1 option:
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/restart missing or empty reg/ranges property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/powerdown-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/softreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/picophyreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/restart missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/powerdown-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/softreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/picophyreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/restart missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/powerdown-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/softreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/picophyreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/restart missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/powerdown-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/softreset-controller missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/picophyreset-controller missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property
arch/arm/boot/dts/stih407-family.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 5a0bad07da9e..00a3838236d1 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -125,24 +125,28 @@
ranges;
compatible = "simple-bus";
- restart {
+ restart: restart-controller@0 {
compatible = "st,stih407-restart";
+ reg = <0 0>;
st,syscfg = <&syscfg_sbc_reg>;
status = "okay";
};
- powerdown: powerdown-controller {
+ powerdown: powerdown-controller@0 {
compatible = "st,stih407-powerdown";
+ reg = <0 0>;
#reset-cells = <1>;
};
- softreset: softreset-controller {
+ softreset: softreset-controller@0 {
compatible = "st,stih407-softreset";
+ reg = <0 0>;
#reset-cells = <1>;
};
- picophyreset: picophyreset-controller {
+ picophyreset: picophyreset-controller@0 {
compatible = "st,stih407-picophyreset";
+ reg = <0 0>;
#reset-cells = <1>;
};
--
1.9.1
From: Patrice Chotard <[email protected]>
Add fake reg property to sound, simple-audio-card, dai-link and
sti_sasg_codec nodes, this allows to fix the following warning
when compiling dtb with W=1 option:
arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/sti-sasg-codec missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/sound missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/sti-sasg-codec missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (unit_address_vs_reg):
Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/sti-sasg-codec missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/sound missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/sti-sasg-codec missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property.
arch/arm/boot/dts/stih407-family.dtsi | 3 ++-
arch/arm/boot/dts/stih410-b2260.dts | 5 +++--
arch/arm/boot/dts/stihxxx-b2120.dtsi | 11 ++++++-----
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 5df827b00eb6..df1a3f1dc5a7 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -894,8 +894,9 @@
status = "disabled";
};
- sti_sasg_codec: sti-sasg-codec {
+ sti_sasg_codec: sti-sasg-codec@0 {
compatible = "st,stih407-sas-codec";
+ reg = <0 0>;
#sound-dai-cells = <1>;
status = "disabled";
st,syscfg = <&syscfg_core>;
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index 8bcd58118dba..03d05a98b7fc 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -181,12 +181,13 @@
status = "okay";
};
- sound {
+ sound: sound@0 {
compatible = "simple-audio-card";
+ reg = <0 0>;
simple-audio-card,name = "STI-B2260";
status = "okay";
- simple-audio-card,dai-link@0 {
+ simple-audio-card,dai-link0 {
/* DAC */
format = "i2s";
mclk-fs = <128>;
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 66c1c6a5eb76..eeae161fc69b 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -147,18 +147,19 @@
status = "okay";
};
- sti_sasg_codec: sti-sasg-codec {
+ sti_sasg_codec: sti-sasg-codec@0 {
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_spdif_out>;
};
- sound {
+ sound: sound@0 {
compatible = "simple-audio-card";
+ reg = <0 0>;
simple-audio-card,name = "STI-B2120";
status = "okay";
- simple-audio-card,dai-link@0 {
+ simple-audio-card,dai-link0 {
/* HDMI */
format = "i2s";
mclk-fs = <128>;
@@ -170,7 +171,7 @@
sound-dai = <&sti_hdmi>;
};
};
- simple-audio-card,dai-link@1 {
+ simple-audio-card,dai-link1 {
/* DAC */
format = "i2s";
mclk-fs = <256>;
@@ -183,7 +184,7 @@
sound-dai = <&sti_sasg_codec 1>;
};
};
- simple-audio-card,dai-link@2 {
+ simple-audio-card,dai-link2 {
/* SPDIF */
format = "left_j";
mclk-fs = <128>;
--
1.9.1
From: Patrice Chotard <[email protected]>
As sti-display-subsystem sub-nodes (sti-compositor, sti-tvout
sti-hdmi, sti-hda and sti-hqvdp) are SoC's IP, we add a fake
reg property.
This allows to fix the following warning when compiling
dtb with W=1 option:
arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
Node /soc/sti-display-subsystem/sti-hda@8d02000 has a unit name, but no reg property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property
arch/arm/boot/dts/stih407.dtsi | 4 ++--
arch/arm/boot/dts/stih410-b2120.dts | 2 +-
arch/arm/boot/dts/stih410.dtsi | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stih407.dtsi b/arch/arm/boot/dts/stih407.dtsi
index 11fdecd9312e..4f01777082f5 100644
--- a/arch/arm/boot/dts/stih407.dtsi
+++ b/arch/arm/boot/dts/stih407.dtsi
@@ -11,11 +11,11 @@
#include <dt-bindings/gpio/gpio.h>
/ {
soc {
- sti-display-subsystem {
+ sti-display-subsystem@0 {
compatible = "st,sti-display-subsystem";
#address-cells = <1>;
#size-cells = <1>;
-
+ reg = <0 0>;
assigned-clocks = <&clk_s_d2_quadfs 0>,
<&clk_s_d2_quadfs 1>,
<&clk_s_c0_pll1 0>,
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 37a42afa0dd1..23199b1b0991 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -61,7 +61,7 @@
status = "okay";
};
- sti-display-subsystem {
+ sti-display-subsystem@0 {
sti-hda@8d02000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
index e4b7e3ddc9ee..d9f964702933 100644
--- a/arch/arm/boot/dts/stih410.dtsi
+++ b/arch/arm/boot/dts/stih410.dtsi
@@ -102,11 +102,12 @@
status = "disabled";
};
- sti-display-subsystem {
+ sti-display-subsystem@0 {
compatible = "st,sti-display-subsystem";
#address-cells = <1>;
#size-cells = <1>;
+ reg = <0 0>;
assigned-clocks = <&clk_s_d2_quadfs 0>,
<&clk_s_d2_quadfs 1>,
<&clk_s_c0_pll1 0>,
--
1.9.1
From: Patrice Chotard <[email protected]>
Add fake reg property to miphy28lp_phy.
This allows to fix the following warning when compiling
dtb with W=1 option:
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/miphy28lp missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/miphy28lp missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/miphy28lp missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/miphy28lp missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property
arch/arm/boot/dts/stih407-family.dtsi | 3 ++-
arch/arm/boot/dts/stih410-b2260.dts | 2 +-
arch/arm/boot/dts/stih418-b2199.dts | 2 +-
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 1608c70f05a9..e279cd07ba67 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -389,12 +389,13 @@
reset-names = "global", "port";
};
- miphy28lp_phy: miphy28lp {
+ miphy28lp_phy: miphy28lp@0 {
compatible = "st,miphy28lp-phy";
st,syscfg = <&syscfg_core>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
+ reg = <0 0>;
phy_port0: port@9b22000 {
reg = <0x9b22000 0xff>,
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index 69c2abcaeda8..cea5c840ca9f 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -200,7 +200,7 @@
};
};
- miphy28lp_phy: miphy28lp {
+ miphy28lp_phy: miphy28lp@0 {
phy_port1: port@9b2a000 {
st,osc-force-ext;
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index 1ce38ce79952..be0bbb05c5ec 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -88,7 +88,7 @@
non-removable;
};
- miphy28lp_phy: miphy28lp {
+ miphy28lp_phy: miphy28lp@0 {
phy_port0: port@9b22000 {
st,osc-rdy;
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 1fd3a2b5b938..66c1c6a5eb76 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -80,7 +80,7 @@
st,i2c-min-sda-pulse-width-us = <5>;
};
- miphy28lp_phy: miphy28lp {
+ miphy28lp_phy: miphy28lp@0 {
phy_port0: port@9b22000 {
st,osc-rdy;
--
1.9.1
From: Patrice Chotard <[email protected]>
For all clock's element inside SoC, add a fake reg property,
this allows to fix the following warnings when compiling
dtb with W=1 option :
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property.
arch/arm/boot/dts/stih407-clock.dtsi | 9 ++++++---
arch/arm/boot/dts/stih410-clock.dtsi | 9 ++++++---
arch/arm/boot/dts/stih418-clock.dtsi | 9 ++++++---
3 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
index b882dcf3a649..1bba47e06ebe 100644
--- a/arch/arm/boot/dts/stih407-clock.dtsi
+++ b/arch/arm/boot/dts/stih407-clock.dtsi
@@ -24,9 +24,10 @@
/*
* ARM Peripheral clock for timers
*/
- arm_periph_clk: clk-m-a9-periphs {
+ arm_periph_clk: clk-m-a9-periphs@0 {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
+ reg = <0 0>;
clocks = <&clk_m_a9>;
clock-div = <2>;
@@ -67,9 +68,10 @@
/*
* ARM Peripheral clock for timers
*/
- clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s {
+ clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s@0 {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
+ reg = <0 0>;
clocks = <&clk_s_c0_flexgen 13>;
@@ -254,9 +256,10 @@
"clk-s-d2-fs0-ch3";
};
- clk_tmdsout_hdmi: clk-tmdsout-hdmi {
+ clk_tmdsout_hdmi: clk-tmdsout-hdmi@0 {
#clock-cells = <0>;
compatible = "fixed-clock";
+ reg = <0 0>;
clock-frequency = <0>;
};
diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index 4df1b2187aa2..41fb1a910d49 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -27,9 +27,10 @@
/*
* ARM Peripheral clock for timers
*/
- arm_periph_clk: clk-m-a9-periphs {
+ arm_periph_clk: clk-m-a9-periphs@0 {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
+ reg = <0 0>;
clocks = <&clk_m_a9>;
clock-div = <2>;
clock-mult = <1>;
@@ -69,9 +70,10 @@
/*
* ARM Peripheral clock for timers
*/
- clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s {
+ clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s@0 {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
+ reg = <0 0>;
clocks = <&clk_s_c0_flexgen 13>;
@@ -266,9 +268,10 @@
"clk-s-d2-fs0-ch3";
};
- clk_tmdsout_hdmi: clk-tmdsout-hdmi {
+ clk_tmdsout_hdmi: clk-tmdsout-hdmi@0 {
#clock-cells = <0>;
compatible = "fixed-clock";
+ reg = <0 0>;
clock-frequency = <0>;
};
diff --git a/arch/arm/boot/dts/stih418-clock.dtsi b/arch/arm/boot/dts/stih418-clock.dtsi
index e68bf28bd038..50413eabe73a 100644
--- a/arch/arm/boot/dts/stih418-clock.dtsi
+++ b/arch/arm/boot/dts/stih418-clock.dtsi
@@ -27,9 +27,10 @@
/*
* ARM Peripheral clock for timers
*/
- arm_periph_clk: clk-m-a9-periphs {
+ arm_periph_clk: clk-m-a9-periphs@0 {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
+ reg = <0 0>;
clocks = <&clk_m_a9>;
clock-div = <2>;
clock-mult = <1>;
@@ -69,9 +70,10 @@
/*
* ARM Peripheral clock for timers
*/
- clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s {
+ clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s@0 {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
+ reg = <0 0>;
clocks = <&clk_s_c0_flexgen 13>;
@@ -259,9 +261,10 @@
"clk-s-d2-fs0-ch3";
};
- clk_tmdsout_hdmi: clk-tmdsout-hdmi {
+ clk_tmdsout_hdmi: clk-tmdsout-hdmi@0 {
#clock-cells = <0>;
compatible = "fixed-clock";
+ reg = <0 0>;
clock-frequency = <0>;
};
--
1.9.1
From: Patrice Chotard <[email protected]>
This clock node is unused, remove it.
This allows to fix the following warnings when compiling
dtb with W=1 option :
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /clocks/clockgen-c0 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /clocks/clockgen-c0 missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /clocks/clockgen-c0 missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ remove clk_ext2f_a9 node
arch/arm/boot/dts/stih407-clock.dtsi | 11 -----------
arch/arm/boot/dts/stih410-clock.dtsi | 11 -----------
arch/arm/boot/dts/stih418-clock.dtsi | 11 -----------
3 files changed, 33 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
index f4e21e2234c9..d63d5e83e1ce 100644
--- a/arch/arm/boot/dts/stih407-clock.dtsi
+++ b/arch/arm/boot/dts/stih407-clock.dtsi
@@ -81,17 +81,6 @@
clock-mult = <1>;
};
- /*
- * Bootloader initialized system infrastructure clock for
- * serial devices.
- */
- clk_ext2f_a9: clockgen-c0 {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <200000000>;
- clock-output-names = "clk-s-icn-reg-0";
- };
-
clockgen-a@90ff000 {
compatible = "st,clkgen-c32";
reg = <0x90ff000 0x1000>;
diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index 9481f8769e8a..c061b67e09d2 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -83,17 +83,6 @@
clock-mult = <1>;
};
- /*
- * Bootloader initialized system infrastructure clock for
- * serial devices.
- */
- clk_ext2f_a9: clockgen-c0 {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <200000000>;
- clock-output-names = "clk-s-icn-reg-0";
- };
-
clockgen-a@90ff000 {
compatible = "st,clkgen-c32";
reg = <0x90ff000 0x1000>;
diff --git a/arch/arm/boot/dts/stih418-clock.dtsi b/arch/arm/boot/dts/stih418-clock.dtsi
index 9e3790198f51..14cdeb5d1599 100644
--- a/arch/arm/boot/dts/stih418-clock.dtsi
+++ b/arch/arm/boot/dts/stih418-clock.dtsi
@@ -83,17 +83,6 @@
clock-mult = <1>;
};
- /*
- * Bootloader initialized system infrastructure clock for
- * serial devices.
- */
- clk_ext2f_a9: clockgen-c0 {
- #clock-cells = <0>;
- compatible = "fixed-clock";
- clock-frequency = <200000000>;
- clock-output-names = "clk-s-icn-reg-0";
- };
-
clockgen-a@90ff000 {
compatible = "st,clkgen-c32";
reg = <0x90ff000 0x1000>;
--
1.9.1
From: Patrice Chotard <[email protected]>
Leds are not part of soc, so nove them outside soc node.
This allows to fix the following warnings when compiling
dtb with W=1 option :
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/leds missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/leds missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/leds missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ none
arch/arm/boot/dts/stih410-b2260.dts | 49 ++++++++++++++++++------------------
arch/arm/boot/dts/stih418-b2199.dts | 26 +++++++++----------
arch/arm/boot/dts/stihxxx-b2120.dtsi | 26 +++++++++----------
3 files changed, 50 insertions(+), 51 deletions(-)
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index faafc7b12951..69c2abcaeda8 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -29,36 +29,35 @@
ethernet0 = ðernet0;
};
- soc {
-
- leds {
- compatible = "gpio-leds";
- user_green_1 {
- label = "User_green_1";
- gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "heartbeat";
- default-state = "off";
- };
+ leds {
+ compatible = "gpio-leds";
+ user_green_1 {
+ label = "User_green_1";
+ gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ default-state = "off";
+ };
- user_green_2 {
- label = "User_green_2";
- gpios = <&pio4 1 GPIO_ACTIVE_LOW>;
- default-state = "off";
- };
+ user_green_2 {
+ label = "User_green_2";
+ gpios = <&pio4 1 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
- user_green_3 {
- label = "User_green_3";
- gpios = <&pio2 1 GPIO_ACTIVE_LOW>;
- default-state = "off";
- };
+ user_green_3 {
+ label = "User_green_3";
+ gpios = <&pio2 1 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
- user_green_4 {
- label = "User_green_4";
- gpios = <&pio2 5 GPIO_ACTIVE_LOW>;
- default-state = "off";
- };
+ user_green_4 {
+ label = "User_green_4";
+ gpios = <&pio2 5 GPIO_ACTIVE_LOW>;
+ default-state = "off";
};
+ };
+ soc {
/* Low speed expansion connector */
uart0: serial@9830000 {
label = "LS-UART0";
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index 5418a0ece659..1ce38ce79952 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -28,24 +28,24 @@
ethernet0 = ðernet0;
};
+ leds {
+ compatible = "gpio-leds";
+ red {
+ label = "Front Panel LED";
+ gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ green {
+ gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ };
+
soc {
sbc_serial0: serial@9530000 {
status = "okay";
};
- leds {
- compatible = "gpio-leds";
- red {
- label = "Front Panel LED";
- gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "heartbeat";
- };
- green {
- gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
- default-state = "off";
- };
- };
-
i2c@9842000 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 68783e8223b8..1fd3a2b5b938 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -10,24 +10,24 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/media/c8sectpfe.h>
/ {
+ leds {
+ compatible = "gpio-leds";
+ red {
+ label = "Front Panel LED";
+ gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ green {
+ gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ };
+
soc {
sbc_serial0: serial@9530000 {
status = "okay";
};
- leds {
- compatible = "gpio-leds";
- red {
- label = "Front Panel LED";
- gpios = <&pio4 1 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "heartbeat";
- };
- green {
- gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
- default-state = "off";
- };
- };
-
pwm0: pwm@9810000 {
status = "okay";
};
--
1.9.1
From: Patrice Chotard <[email protected]>
Add fake reg property to irq-syscfg node.
This allows to fix the following warning when compiling
dtb with W=1 option:
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/irq-syscfg missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/irq-syscfg missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/irq-syscfg missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/irq-syscfg missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property
arch/arm/boot/dts/stih407-family.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index e279cd07ba67..c8dc659fd14e 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -181,8 +181,9 @@
reg = <0x94b5100 0x1000>;
};
- irq-syscfg {
+ irq-syscfg@0 {
compatible = "st,stih407-irq-syscfg";
+ reg = <0 0>;
st,syscfg = <&syscfg_core>;
st,irq-device = <ST_IRQ_SYSCFG_PMU_0>,
<ST_IRQ_SYSCFG_PMU_1>;
--
1.9.1
On Mon, Feb 12, 2018 at 8:42 AM, <[email protected]> wrote:
> From: Patrice Chotard <[email protected]>
>
> Remove leading 0x and 0s from bindings notation
> Add missing unit-address and remove some which are useless.
>
> This allows to fix several warnings like :
>
> Warning (unit_address_vs_reg): Node XXXX has a reg or ranges property, but no unit name
> Warning (simple_bus_reg): Node XXXX simple-bus unit address format error, expected "123456"
> Warning (unit_address_vs_reg): Node XXXX has a unit name, but no reg property
>
> Signed-off-by: Patrice Chotard <[email protected]>
> ---
[...]
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index a29090077fdf..53c6888d1fc0 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -45,7 +45,7 @@
> };
>
> soc {
> - pin-controller-sbc {
> + pin-controller-sbc@961f080 {
While you're here changing the node name, these all should be "pinctrl@..."
With that,
Reviewed-by: Rob Herring <[email protected]>
On Mon, Feb 12, 2018 at 8:43 AM, <[email protected]> wrote:
> From: Patrice Chotard <[email protected]>
>
> Add fake reg property to sound, simple-audio-card, dai-link and
> sti_sasg_codec nodes, this allows to fix the following warning
> when compiling dtb with W=1 option:
>
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
> Node /soc/sound missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (unit_address_vs_reg):
> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /soc/sti-sasg-codec missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /soc/sound missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>
> Signed-off-by: Patrice Chotard <[email protected]>
> ---
>
> v2: _ add a fake reg property to node without reg property.
>
> arch/arm/boot/dts/stih407-family.dtsi | 3 ++-
> arch/arm/boot/dts/stih410-b2260.dts | 5 +++--
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 11 ++++++-----
> 3 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 5df827b00eb6..df1a3f1dc5a7 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -894,8 +894,9 @@
> status = "disabled";
> };
>
> - sti_sasg_codec: sti-sasg-codec {
> + sti_sasg_codec: sti-sasg-codec@0 {
> compatible = "st,stih407-sas-codec";
> + reg = <0 0>;
> #sound-dai-cells = <1>;
> status = "disabled";
> st,syscfg = <&syscfg_core>;
This should probably be a child of syscfg to fix this. And if this
block has a dedicated set of registers, then use reg to define those
(even though regmap/syscon doesn't need it).
> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
> index 8bcd58118dba..03d05a98b7fc 100644
> --- a/arch/arm/boot/dts/stih410-b2260.dts
> +++ b/arch/arm/boot/dts/stih410-b2260.dts
> @@ -181,12 +181,13 @@
> status = "okay";
> };
>
> - sound {
> + sound: sound@0 {
I'd move this up to top level.
Rob
From: Patrice Chotard <[email protected]>
As st231-gp0, st231-delta are part of SoC, we add a fake reg
property instead of moving all these nodes outside soc node.
This allows to fix the following warning when compiling
dtb with W=1 option:
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/st231-gp0 missing or empty reg/ranges property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/st231-delta missing or empty reg/ranges property
arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
Node /soc/delta0 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/st231-gp0 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/st231-delta missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/delta0 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/st231-gp0 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/st231-delta missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
Node /soc/delta0 missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/st231-gp0 missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/st231-delta missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/delta0 missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property
arch/arm/boot/dts/stih407-family.dtsi | 9 ++++++---
arch/arm/boot/dts/stih410.dtsi | 2 +-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index c8dc659fd14e..5a0bad07da9e 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -805,8 +805,9 @@
status = "okay";
};
- st231_gp0: st231-gp0 {
+ st231_gp0: st231-gp0@0 {
compatible = "st,st231-rproc";
+ reg = <0 0>;
memory-region = <&gp0_reserved>;
resets = <&softreset STIH407_ST231_GP0_SOFTRESET>;
reset-names = "sw_reset";
@@ -818,8 +819,9 @@
mboxes = <&mailbox0 0 2>, <&mailbox2 0 1>, <&mailbox0 0 3>, <&mailbox2 0 0>;
};
- st231_delta: st231-delta {
+ st231_delta: st231-delta@0 {
compatible = "st,st231-rproc";
+ reg = <0 0>;
memory-region = <&delta_reserved>;
resets = <&softreset STIH407_ST231_DMU_SOFTRESET>;
reset-names = "sw_reset";
@@ -982,8 +984,9 @@
status = "disabled";
};
- delta0 {
+ delta0@0 {
compatible = "st,st-delta";
+ reg = <0 0>;
clock-names = "delta",
"delta-st231",
"delta-flash-promip";
diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
index d9f964702933..815df2f7c103 100644
--- a/arch/arm/boot/dts/stih410.dtsi
+++ b/arch/arm/boot/dts/stih410.dtsi
@@ -274,7 +274,7 @@
interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
};
- delta0 {
+ delta0@0 {
compatible = "st,st-delta";
clock-names = "delta",
"delta-st231",
--
1.9.1
From: Patrice Chotard <[email protected]>
Remove leading 0x and 0s from bindings notation
Add missing unit-address and remove some which are useless.
This allows to fix several warnings like :
Warning (unit_address_vs_reg): Node XXXX has a reg or ranges property, but no unit name
Warning (simple_bus_reg): Node XXXX simple-bus unit address format error, expected "123456"
Warning (unit_address_vs_reg): Node XXXX has a unit name, but no reg property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ none
arch/arm/boot/dts/stih407-b2120.dts | 2 +-
arch/arm/boot/dts/stih407-clock.dtsi | 4 ++--
arch/arm/boot/dts/stih407-family.dtsi | 8 ++++----
arch/arm/boot/dts/stih407-pinctrl.dtsi | 10 +++++-----
arch/arm/boot/dts/stih410-b2120.dts | 2 +-
arch/arm/boot/dts/stih410-b2260.dts | 4 ++--
arch/arm/boot/dts/stih410-clock.dtsi | 4 ++--
arch/arm/boot/dts/stih410-pinctrl.dtsi | 2 +-
arch/arm/boot/dts/stih410.dtsi | 2 +-
arch/arm/boot/dts/stih418-b2199.dts | 4 ++--
arch/arm/boot/dts/stih418-clock.dtsi | 4 ++--
arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++--
12 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index c8ad905d0309..cf8bc8a8b947 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -18,7 +18,7 @@
linux,stdout-path = &sbc_serial0;
};
- memory {
+ memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x80000000>;
};
diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
index d0a24d9e517a..b882dcf3a649 100644
--- a/arch/arm/boot/dts/stih407-clock.dtsi
+++ b/arch/arm/boot/dts/stih407-clock.dtsi
@@ -83,7 +83,7 @@
* Bootloader initialized system infrastructure clock for
* serial devices.
*/
- clk_ext2f_a9: clockgen-c0@13 {
+ clk_ext2f_a9: clockgen-c0 {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <200000000>;
@@ -260,7 +260,7 @@
clock-frequency = <0>;
};
- clockgen-d2@x9106000 {
+ clockgen-d2@9106000 {
compatible = "st,clkgen-c32";
reg = <0x9106000 0x1000>;
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index cf3756976c39..1608c70f05a9 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -92,7 +92,7 @@
clocks = <&arm_periph_clk>;
};
- l2: cache-controller {
+ l2: cache-controller@8762000 {
compatible = "arm,pl310-cache";
reg = <0x08762000 0x1000>;
arm,data-latency = <3 3 3>;
@@ -389,7 +389,7 @@
reset-names = "global", "port";
};
- miphy28lp_phy: miphy28lp@9b22000 {
+ miphy28lp_phy: miphy28lp {
compatible = "st,miphy28lp-phy";
st,syscfg = <&syscfg_core>;
#address-cells = <1>;
@@ -803,7 +803,7 @@
status = "okay";
};
- st231_gp0: st231-gp0@0 {
+ st231_gp0: st231-gp0 {
compatible = "st,st231-rproc";
memory-region = <&gp0_reserved>;
resets = <&softreset STIH407_ST231_GP0_SOFTRESET>;
@@ -816,7 +816,7 @@
mboxes = <&mailbox0 0 2>, <&mailbox2 0 1>, <&mailbox0 0 3>, <&mailbox2 0 0>;
};
- st231_delta: st231-delta@0 {
+ st231_delta: st231-delta {
compatible = "st,st231-rproc";
memory-region = <&delta_reserved>;
resets = <&softreset STIH407_ST231_DMU_SOFTRESET>;
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index a29090077fdf..53c6888d1fc0 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -45,7 +45,7 @@
};
soc {
- pin-controller-sbc {
+ pin-controller-sbc@961f080 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,stih407-sbc-pinctrl";
@@ -369,7 +369,7 @@
};
};
- pin-controller-front0 {
+ pin-controller-front0@920f080 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,stih407-front-pinctrl";
@@ -929,7 +929,7 @@
};
};
- pin-controller-front1 {
+ pin-controller-front1@921f080 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,stih407-front-pinctrl";
@@ -962,7 +962,7 @@
};
};
- pin-controller-rear {
+ pin-controller-rear@922f080 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,stih407-rear-pinctrl";
@@ -1157,7 +1157,7 @@
};
};
- pin-controller-flash {
+ pin-controller-flash@923f080 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,stih407-flash-pinctrl";
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 9830be577433..37a42afa0dd1 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -18,7 +18,7 @@
linux,stdout-path = &sbc_serial0;
};
- memory {
+ memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x80000000>;
};
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index c663b70c43a7..faafc7b12951 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -19,7 +19,7 @@
linux,stdout-path = &uart1;
};
- memory {
+ memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x40000000>;
};
@@ -201,7 +201,7 @@
};
};
- miphy28lp_phy: miphy28lp@9b22000 {
+ miphy28lp_phy: miphy28lp {
phy_port1: port@9b2a000 {
st,osc-force-ext;
diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi
index fde5df17f575..4df1b2187aa2 100644
--- a/arch/arm/boot/dts/stih410-clock.dtsi
+++ b/arch/arm/boot/dts/stih410-clock.dtsi
@@ -85,7 +85,7 @@
* Bootloader initialized system infrastructure clock for
* serial devices.
*/
- clk_ext2f_a9: clockgen-c0@13 {
+ clk_ext2f_a9: clockgen-c0 {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <200000000>;
@@ -272,7 +272,7 @@
clock-frequency = <0>;
};
- clockgen-d2@x9106000 {
+ clockgen-d2@9106000 {
compatible = "st,clkgen-c32";
reg = <0x9106000 0x1000>;
diff --git a/arch/arm/boot/dts/stih410-pinctrl.dtsi b/arch/arm/boot/dts/stih410-pinctrl.dtsi
index b3e9dfc81c07..5ae1fd66c0b8 100644
--- a/arch/arm/boot/dts/stih410-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih410-pinctrl.dtsi
@@ -10,7 +10,7 @@
/ {
soc {
- pin-controller-rear {
+ pin-controller-rear@922f080 {
usb0 {
pinctrl_usb0: usb2-0 {
diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
index 68b5ff91d6a7..e4b7e3ddc9ee 100644
--- a/arch/arm/boot/dts/stih410.dtsi
+++ b/arch/arm/boot/dts/stih410.dtsi
@@ -235,7 +235,7 @@
<&clk_s_d2_quadfs 1>;
};
- sti-hqvdp@9c000000 {
+ sti-hqvdp@9c00000 {
compatible = "st,stih407-hqvdp";
reg = <0x9C00000 0x100000>;
clock-names = "hqvdp", "pix_main";
diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts
index 4e6d915c85ff..5418a0ece659 100644
--- a/arch/arm/boot/dts/stih418-b2199.dts
+++ b/arch/arm/boot/dts/stih418-b2199.dts
@@ -18,7 +18,7 @@
linux,stdout-path = &sbc_serial0;
};
- memory {
+ memory@40000000 {
device_type = "memory";
reg = <0x40000000 0xc0000000>;
};
@@ -88,7 +88,7 @@
non-removable;
};
- miphy28lp_phy: miphy28lp@9b22000 {
+ miphy28lp_phy: miphy28lp {
phy_port0: port@9b22000 {
st,osc-rdy;
diff --git a/arch/arm/boot/dts/stih418-clock.dtsi b/arch/arm/boot/dts/stih418-clock.dtsi
index 9a157c1a99b1..e68bf28bd038 100644
--- a/arch/arm/boot/dts/stih418-clock.dtsi
+++ b/arch/arm/boot/dts/stih418-clock.dtsi
@@ -85,7 +85,7 @@
* Bootloader initialized system infrastructure clock for
* serial devices.
*/
- clk_ext2f_a9: clockgen-c0@13 {
+ clk_ext2f_a9: clockgen-c0 {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <200000000>;
@@ -265,7 +265,7 @@
clock-frequency = <0>;
};
- clockgen-d2@x9106000 {
+ clockgen-d2@9106000 {
compatible = "st,clkgen-c32";
reg = <0x9106000 0x1000>;
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 7f80c2c414c8..68783e8223b8 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -80,7 +80,7 @@
st,i2c-min-sda-pulse-width-us = <5>;
};
- miphy28lp_phy: miphy28lp@9b22000 {
+ miphy28lp_phy: miphy28lp {
phy_port0: port@9b22000 {
st,osc-rdy;
@@ -126,7 +126,7 @@
clock-names = "c8sectpfe";
/* tsin0 is TSA on NIMA */
- tsin0: port@0 {
+ tsin0: port {
tsin-num = <0>;
serial-not-parallel;
i2c-bus = <&ssc2>;
--
1.9.1
From: Patrice Chotard <[email protected]>
Add fake reg property for usb2_picophy nodes.
This allows to fix the following warning when compiling dtb
with W=1 option :
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/phy2 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/phy3 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/phy2 missing or empty reg/ranges property
arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
Node /soc/phy3 missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/phy2 missing or empty reg/ranges property
arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
Node /soc/phy3 missing or empty reg/ranges property
Signed-off-by: Patrice Chotard <[email protected]>
---
v2: _ add a fake reg property to node without reg property.
arch/arm/boot/dts/stih407-family.dtsi | 3 ++-
arch/arm/boot/dts/stih410-b2120.dts | 4 ++--
arch/arm/boot/dts/stih410-b2260.dts | 4 ++--
arch/arm/boot/dts/stih410.dtsi | 6 ++++--
arch/arm/boot/dts/stih418.dtsi | 6 ++++--
5 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 00a3838236d1..5df827b00eb6 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -385,8 +385,9 @@
status = "disabled";
};
- usb2_picophy0: phy1 {
+ usb2_picophy0: phy1@0 {
compatible = "st,stih407-usb2-phy";
+ reg = <0 0>;
#phy-cells = <0>;
st,syscfg = <&syscfg_core 0x100 0xf4>;
resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts
index 23199b1b0991..d1d908b9e34c 100644
--- a/arch/arm/boot/dts/stih410-b2120.dts
+++ b/arch/arm/boot/dts/stih410-b2120.dts
@@ -37,11 +37,11 @@
sd-uhs-ddr50;
};
- usb2_picophy1: phy2 {
+ usb2_picophy1: phy2@0 {
status = "okay";
};
- usb2_picophy2: phy3 {
+ usb2_picophy2: phy3@0 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index cea5c840ca9f..8bcd58118dba 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -127,11 +127,11 @@
status = "okay";
};
- usb2_picophy1: phy2 {
+ usb2_picophy1: phy2@0 {
status = "okay";
};
- usb2_picophy2: phy3 {
+ usb2_picophy2: phy3@0 {
status = "okay";
};
diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
index 815df2f7c103..bfbc73743b29 100644
--- a/arch/arm/boot/dts/stih410.dtsi
+++ b/arch/arm/boot/dts/stih410.dtsi
@@ -16,8 +16,9 @@
};
soc {
- usb2_picophy1: phy2 {
+ usb2_picophy1: phy2@0 {
compatible = "st,stih407-usb2-phy";
+ reg = <0 0>;
#phy-cells = <0>;
st,syscfg = <&syscfg_core 0xf8 0xf4>;
resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
@@ -27,8 +28,9 @@
status = "disabled";
};
- usb2_picophy2: phy3 {
+ usb2_picophy2: phy3@0 {
compatible = "st,stih407-usb2-phy";
+ reg = <0 0>;
#phy-cells = <0>;
st,syscfg = <&syscfg_core 0xfc 0xf4>;
resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
diff --git a/arch/arm/boot/dts/stih418.dtsi b/arch/arm/boot/dts/stih418.dtsi
index e6525ab4d9bb..0efb3cd6a86e 100644
--- a/arch/arm/boot/dts/stih418.dtsi
+++ b/arch/arm/boot/dts/stih418.dtsi
@@ -30,8 +30,9 @@
};
soc {
- usb2_picophy1: phy2 {
+ usb2_picophy1: phy2@0 {
compatible = "st,stih407-usb2-phy";
+ reg = <0 0>;
#phy-cells = <0>;
st,syscfg = <&syscfg_core 0xf8 0xf4>;
resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
@@ -39,8 +40,9 @@
reset-names = "global", "port";
};
- usb2_picophy2: phy3 {
+ usb2_picophy2: phy3@0 {
compatible = "st,stih407-usb2-phy";
+ reg = <0 0>;
#phy-cells = <0>;
st,syscfg = <&syscfg_core 0xfc 0xf4>;
resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
--
1.9.1
On Mon, Feb 12, 2018 at 8:43 AM, <[email protected]> wrote:
> From: Patrice Chotard <[email protected]>
>
> For all clock's element inside SoC, add a fake reg property,
> this allows to fix the following warnings when compiling
> dtb with W=1 option :
>
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>
> Signed-off-by: Patrice Chotard <[email protected]>
> ---
>
> v2: _ add a fake reg property to node without reg property.
>
> arch/arm/boot/dts/stih407-clock.dtsi | 9 ++++++---
> arch/arm/boot/dts/stih410-clock.dtsi | 9 ++++++---
> arch/arm/boot/dts/stih418-clock.dtsi | 9 ++++++---
> 3 files changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
> index b882dcf3a649..1bba47e06ebe 100644
> --- a/arch/arm/boot/dts/stih407-clock.dtsi
> +++ b/arch/arm/boot/dts/stih407-clock.dtsi
> @@ -24,9 +24,10 @@
> /*
> * ARM Peripheral clock for timers
> */
> - arm_periph_clk: clk-m-a9-periphs {
> + arm_periph_clk: clk-m-a9-periphs@0 {
> #clock-cells = <0>;
> compatible = "fixed-factor-clock";
> + reg = <0 0>;
Don't do this. The correct fix is change the location of these nodes
to be under whatever controls them.
Rob
Hi Rob
On 02/12/2018 04:40 PM, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 8:43 AM, <[email protected]> wrote:
>> From: Patrice Chotard <[email protected]>
>>
>> Add fake reg property to sound, simple-audio-card, dai-link and
>> sti_sasg_codec nodes, this allows to fix the following warning
>> when compiling dtb with W=1 option:
>>
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
>> Node /soc/sound missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /soc/sound missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>>
>> Signed-off-by: Patrice Chotard <[email protected]>
>> ---
>>
>> v2: _ add a fake reg property to node without reg property.
>>
>> arch/arm/boot/dts/stih407-family.dtsi | 3 ++-
>> arch/arm/boot/dts/stih410-b2260.dts | 5 +++--
>> arch/arm/boot/dts/stihxxx-b2120.dtsi | 11 ++++++-----
>> 3 files changed, 11 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
>> index 5df827b00eb6..df1a3f1dc5a7 100644
>> --- a/arch/arm/boot/dts/stih407-family.dtsi
>> +++ b/arch/arm/boot/dts/stih407-family.dtsi
>> @@ -894,8 +894,9 @@
>> status = "disabled";
>> };
>>
>> - sti_sasg_codec: sti-sasg-codec {
>> + sti_sasg_codec: sti-sasg-codec@0 {
>> compatible = "st,stih407-sas-codec";
>> + reg = <0 0>;
>> #sound-dai-cells = <1>;
>> status = "disabled";
>> st,syscfg = <&syscfg_core>;
>
> This should probably be a child of syscfg to fix this. And if this
> block has a dedicated set of registers, then use reg to define those
> (even though regmap/syscon doesn't need it).
Ok, i will mode this node
>
>> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
>> index 8bcd58118dba..03d05a98b7fc 100644
>> --- a/arch/arm/boot/dts/stih410-b2260.dts
>> +++ b/arch/arm/boot/dts/stih410-b2260.dts
>> @@ -181,12 +181,13 @@
>> status = "okay";
>> };
>>
>> - sound {
>> + sound: sound@0 {
>
> I'd move this up to top level.
Ok
Thanks
Patrice
>
> Rob
>
Hi Rob
On 02/12/2018 04:22 PM, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 8:43 AM, <[email protected]> wrote:
>> From: Patrice Chotard <[email protected]>
>>
>> For all clock's element inside SoC, add a fake reg property,
>> this allows to fix the following warnings when compiling
>> dtb with W=1 option :
>>
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
>> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
>> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
>> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>>
>> Signed-off-by: Patrice Chotard <[email protected]>
>> ---
>>
>> v2: _ add a fake reg property to node without reg property.
>>
>> arch/arm/boot/dts/stih407-clock.dtsi | 9 ++++++---
>> arch/arm/boot/dts/stih410-clock.dtsi | 9 ++++++---
>> arch/arm/boot/dts/stih418-clock.dtsi | 9 ++++++---
>> 3 files changed, 18 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
>> index b882dcf3a649..1bba47e06ebe 100644
>> --- a/arch/arm/boot/dts/stih407-clock.dtsi
>> +++ b/arch/arm/boot/dts/stih407-clock.dtsi
>> @@ -24,9 +24,10 @@
>> /*
>> * ARM Peripheral clock for timers
>> */
>> - arm_periph_clk: clk-m-a9-periphs {
>> + arm_periph_clk: clk-m-a9-periphs@0 {
>> #clock-cells = <0>;
>> compatible = "fixed-factor-clock";
>> + reg = <0 0>;
>
> Don't do this. The correct fix is change the location of these nodes
> to be under whatever controls them.
>
Ok i will put this node as a child of clockgen-a9@92b0000
Thanks
Patrice
> Rob
>