2018-02-28 09:21:51

by Yisheng Xie

Subject: [PATCH] checkpatch: avoid error report caused by syzbot

syzbot request to add his reported-by when fix the bug find by syzbot.
However, it will trigger a error when use checkpatch:

ERROR: Unrecognized email address: '[email protected]'

For it include '+' in email and make regular expression works abnomal. Fix
it by adding check for syzbot.

Signed-off-by: Yisheng Xie <[email protected]>
---
scripts/checkpatch.pl | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3d40403..19f3e26 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1075,7 +1075,11 @@ sub parse_email {
} elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
$address = $1;
$comment = $2 if defined $2;
- $formatted_email =~ s/$address.*$//;
+ if ($address =~ /^syzbot.*\@syzkaller\.appspotmail\.com$/) {
+ $formatted_email = "";
+ } else {
+ $formatted_email =~ s/^($address).*$//;
+ }
$name = $formatted_email;
$name = trim($name);
$name =~ s/^\"|\"$//g;
--
1.7.12.4

2018-02-28 16:38:29

by Joe Perches

Subject: Re: [PATCH] checkpatch: avoid error report caused by syzbot

On Wed, 2018-02-28 at 17:10 +0800, Yisheng Xie wrote:
> syzbot request to add his reported-by when fix the bug find by syzbot.
> However, it will trigger a error when use checkpatch:
>
> ERROR: Unrecognized email address: '[email protected]'
>
> For it include '+' in email and make regular expression works abnomal. Fix
> it by adding check for syzbot.
>
> Signed-off-by: Yisheng Xie <[email protected]>

Nack.

There's a proper patch already in -next

commit 14e45b3ecdb03211ab32656cd84e66fd6a28343e
Author: Joe Perches <[email protected]>
Date: Thu Feb 22 09:59:45 2018 +1100

checkpatch: improve parse_email signature checking

Bare email addresses with non alphanumeric characters require escape
quoting before being substituted in the parse_email routine.

e.g. Reported-by: [email protected]

Do so.

Link: http://lkml.kernel.org/r/[email protected]

2018-03-01 00:46:35

by Yisheng Xie

Subject: Re: [PATCH] checkpatch: avoid error report caused by syzbot

Hi Joe,

On 2018/3/1 0:37, Joe Perches wrote:
> On Wed, 2018-02-28 at 17:10 +0800, Yisheng Xie wrote:
>> syzbot request to add his reported-by when fix the bug find by syzbot.
>> However, it will trigger a error when use checkpatch:
>>
>> ERROR: Unrecognized email address: '[email protected]'
>>
>> For it include '+' in email and make regular expression works abnomal. Fix
>> it by adding check for syzbot.
>>
>> Signed-off-by: Yisheng Xie <[email protected]>
>
> Nack.
>
> There's a proper patch already in -next
>

Thanks for the information.

Thanks
Yisheng

> commit 14e45b3ecdb03211ab32656cd84e66fd6a28343e
> Author: Joe Perches <[email protected]>
> Date: Thu Feb 22 09:59:45 2018 +1100
>
> checkpatch: improve parse_email signature checking
>
> Bare email addresses with non alphanumeric characters require escape
> quoting before being substituted in the parse_email routine.
>
> e.g. Reported-by: [email protected]
>
> Do so.
>
> Link: http://lkml.kernel.org/r/[email protected]
>
>
> .
>