Since the remove callback is removed, the snd_soc_unregister_component()
is missing when remove device. Using devm_snd_soc_register_component()
instead of snd_soc_register_component().
Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component")
Signed-off-by: Wei Yongjun <[email protected]>
---
sound/soc/codecs/wm8400.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c
index c237365..57b2206 100644
--- a/sound/soc/codecs/wm8400.c
+++ b/sound/soc/codecs/wm8400.c
@@ -1343,7 +1343,7 @@ static void wm8400_component_remove(struct snd_soc_component *component)
static int wm8400_probe(struct platform_device *pdev)
{
- return snd_soc_register_component(&pdev->dev,
+ return devm_snd_soc_register_component(&pdev->dev,
&soc_component_dev_wm8400,
&wm8400_dai, 1);
}
On Fri, Mar 16, 2018 at 07:32:07AM +0000, Wei Yongjun wrote:
> Since the remove callback is removed, the snd_soc_unregister_component()
> is missing when remove device. Using devm_snd_soc_register_component()
> instead of snd_soc_register_component().
>
> Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
Thanks for spotting this.
Acked-by: Charles Keepax <[email protected]>
Thanks,
Charles
The patch
ASoC: wm8400: Use devm_snd_soc_register_component()
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 822e70a8210b7038e1f54c43ca6c76c3b9f89803 Mon Sep 17 00:00:00 2001
From: "weiyongjun (A)" <[email protected]>
Date: Fri, 16 Mar 2018 07:32:07 +0000
Subject: [PATCH] ASoC: wm8400: Use devm_snd_soc_register_component()
Since the remove callback is removed, the snd_soc_unregister_component()
is missing when remove device. Using devm_snd_soc_register_component()
instead of snd_soc_register_component().
Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component")
Signed-off-by: Wei Yongjun <[email protected]>
Acked-by: Charles Keepax <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
sound/soc/codecs/wm8400.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c
index c237365d1184..57b22065a45d 100644
--- a/sound/soc/codecs/wm8400.c
+++ b/sound/soc/codecs/wm8400.c
@@ -1343,7 +1343,7 @@ static const struct snd_soc_component_driver soc_component_dev_wm8400 = {
static int wm8400_probe(struct platform_device *pdev)
{
- return snd_soc_register_component(&pdev->dev,
+ return devm_snd_soc_register_component(&pdev->dev,
&soc_component_dev_wm8400,
&wm8400_dai, 1);
}
--
2.16.2
Hi Wei
> Since the remove callback is removed, the snd_soc_unregister_component()
> is missing when remove device. Using devm_snd_soc_register_component()
> instead of snd_soc_register_component().
>
> Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
Thank you for your patch
Acked-by: Kuninori Morimoto <[email protected]>
Best regards
---
Kuninori Morimoto