2024-01-08 10:15:22

by Minjie Du

Subject: [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_volume()

key might contain private information, so use kfree_sensitive to free it.
In fscache_free_volume() use kfree_sensitive().

Signed-off-by: Minjie Du <[email protected]>
---
fs/netfs/fscache_volume.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/netfs/fscache_volume.c b/fs/netfs/fscache_volume.c
index cdf991bdd9de..648a7d6eaa6a 100644
--- a/fs/netfs/fscache_volume.c
+++ b/fs/netfs/fscache_volume.c
@@ -397,7 +397,7 @@ static void fscache_free_volume(struct fscache_volume *volume)
fscache_unhash_volume(volume);

trace_fscache_volume(volume->debug_id, 0, fscache_volume_free);
- kfree(volume->key);
+ kfree_sensitive(volume->key);
kfree(volume);
fscache_stat_d(&fscache_n_volumes);
fscache_put_cache(cache, fscache_cache_put_volume);
--
2.39.0

2024-01-08 13:56:22

by David Howells

Subject: Re: [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_volume()

You sent this twice - I replied to the other post. But this is an unnecessary
use of kfree_sensitive() as the key is made public.

David