2021-09-07 12:30:11

by Jan Beulich

Subject: [PATCH 09/12] swiotlb-xen: drop DEFAULT_NSLABS

It was introduced by 4035b43da6da ("xen-swiotlb: remove xen_set_nslabs")
and then not removed by 2d29960af0be ("swiotlb: dynamically allocate
io_tlb_default_mem").

Signed-off-by: Jan Beulich <[email protected]>

--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -152,8 +152,6 @@ static const char *xen_swiotlb_error(enu
return "";
}

-#define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE)
-
int xen_swiotlb_init(void)
{
enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN;

2021-09-08 07:50:27

by Christoph Hellwig

Subject: Re: [PATCH 09/12] swiotlb-xen: drop DEFAULT_NSLABS

On Tue, Sep 07, 2021 at 02:07:47PM +0200, Jan Beulich wrote:
> It was introduced by 4035b43da6da ("xen-swiotlb: remove xen_set_nslabs")
> and then not removed by 2d29960af0be ("swiotlb: dynamically allocate
> io_tlb_default_mem").
>
> Signed-off-by: Jan Beulich <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2021-09-10 23:32:16

by Stefano Stabellini

Subject: Re: [PATCH 09/12] swiotlb-xen: drop DEFAULT_NSLABS

On Tue, 7 Sep 2021, Jan Beulich wrote:
> It was introduced by 4035b43da6da ("xen-swiotlb: remove xen_set_nslabs")
> and then not removed by 2d29960af0be ("swiotlb: dynamically allocate
> io_tlb_default_mem").
>
> Signed-off-by: Jan Beulich <[email protected]>

Reviewed-by: Stefano Stabellini <[email protected]>


> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -152,8 +152,6 @@ static const char *xen_swiotlb_error(enu
> return "";
> }
>
> -#define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE)
> -
> int xen_swiotlb_init(void)
> {
> enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN;
>