Signed-off-by: Parth Y Shah <[email protected]>
---
drivers/usb/gadget/configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index efba66c..0675b4a 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
list_move_tail(&f->list, &cfg->func_list);
if (f->unbind) {
dev_dbg(&gi->cdev.gadget->dev,
- "unbind function '%s'/%p\n",
- f->name, f);
+ "unbind function '%s'/%p\n",
+ f->name, f);
f->unbind(c, f);
}
}
--
2.7.4
On Wed, 2018-06-13 at 17:55 +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <[email protected]>
-ENOCHANGELOG
Why do you think this is an error?
Why is the dev_dbg useful at all?
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
[]
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> dev_dbg(&gi->cdev.gadget->dev,
> - "unbind function '%s'/%p\n",
> - f->name, f);
> + "unbind function '%s'/%p\n",
> + f->name, f);
> f->unbind(c, f);
> }
> }
On Wed, Jun 13, 2018 at 05:55:10PM +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <[email protected]>
> ---
> drivers/usb/gadget/configfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index efba66c..0675b4a 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> dev_dbg(&gi->cdev.gadget->dev,
> - "unbind function '%s'/%p\n",
> - f->name, f);
> + "unbind function '%s'/%p\n",
> + f->name, f);
I see no "error" with the original code here, please explain why this
needs to be changed.
thanks,
greg k-h
ERROR: code indent should use tabs where possible
Here, spaces are replaced by a tab in 2 lines.
Signed-off-by: Parth Y Shah <[email protected]>
---
Changes since v1:
* Updated commit description
* Removed one extra tab and replaced spaces with tab to resolve
checkpatch error
drivers/usb/gadget/configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index efba66c..0251299 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
list_move_tail(&f->list, &cfg->func_list);
if (f->unbind) {
dev_dbg(&gi->cdev.gadget->dev,
- "unbind function '%s'/%p\n",
- f->name, f);
+ "unbind function '%s'/%p\n",
+ f->name, f);
f->unbind(c, f);
}
}
--
2.7.4
On Thu, Jun 14, 2018 at 12:02:46PM +0530, Parth Y Shah wrote:
> ERROR: code indent should use tabs where possible
>
> Here, spaces are replaced by a tab in 2 lines.
>
> Signed-off-by: Parth Y Shah <[email protected]>
Your subject line needs work, please see how other subject lines are
composed for this subsystem.
Also note, please do not use anything but the drivers/staging/ area of
the kernel for beginning "I'm going to do checkpatch cleanups" type of
"learning to get changes into the kernel" work. That is a great place
to start with this, not in other subsystems where you might have
reviewers who do not care so much about whitespace cleanups like this.
So please learn the process there, and when you have it all working
well, then you could move on to other subsystems and areas of the
kernel, like this one, if you want to.
thanks,
greg k-h