2018-07-11 13:19:31

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

Fixes the following sparse warning:

drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning:
symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
index 3459b9e..281c42a 100644
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -225,7 +225,7 @@ static int sun8i_dw_hdmi_remove(struct platform_device *pdev)
};
MODULE_DEVICE_TABLE(of, sun8i_dw_hdmi_dt_ids);

-struct platform_driver sun8i_dw_hdmi_pltfm_driver = {
+static struct platform_driver sun8i_dw_hdmi_pltfm_driver = {
.probe = sun8i_dw_hdmi_probe,
.remove = sun8i_dw_hdmi_remove,
.driver = {



2018-07-12 07:35:15

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

On Wed, Jul 11, 2018 at 01:22:47PM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning:
> symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (446.00 B)
signature.asc (849.00 B)
Download all attachments